History

convert script engine variables from QSharedPointer to std::shared_ptr

Heather Anderson committed 5 years ago

Commit 70fbe761 parent 82535ca49 files · +194 −164Browse files

Showing the changes to libraries/script-engine/src/qtscript/ScriptEngineQtScript.h (1 of 49 files). Show all

Unified · Split

libraries/script-engine/src/qtscript/ScriptEngineQtScript.h+5−5
@@ -16,12 +16,12 @@ · 15 unmodified lines
1616 #ifndef hifi_ScriptEngineQtScript_h
1717 #define hifi_ScriptEngineQtScript_h
1818
19+#include <memory>
20+
1921 #include <QtCore/QByteArray>
20−#include <QtCore/QEnableSharedFromThis>
2122 #include <QtCore/QMetaEnum>
2223 #include <QtCore/QObject>
2324 #include <QtCore/QPointer>
24−#include <QtCore/QSharedPointer>
2525 #include <QtCore/QString>
2626
2727 #include <QtScript/QScriptEngine>
@@ -35,15 +35,15 @@ class ScriptContextQtWrapper; · 7 unmodified lines
3535 class ScriptContextQtAgent;
3636 class ScriptEngineQtScript;
3737 class ScriptManager;
38−using ScriptEngineQtScriptPointer = QSharedPointer<ScriptEngineQtScript>;
39−using ScriptContextQtPointer = QSharedPointer<ScriptContextQtWrapper>;
38+using ScriptEngineQtScriptPointer = std::shared_ptr<ScriptEngineQtScript>;
39+using ScriptContextQtPointer = std::shared_ptr<ScriptContextQtWrapper>;
4040
4141 Q_DECLARE_METATYPE(ScriptEngineQtScriptPointer);
4242
4343 /// [QtScript] Implements ScriptEngine for QtScript and translates calls for QScriptEngine
4444 class ScriptEngineQtScript final : public QScriptEngine,
4545 public ScriptEngine,
46− public QEnableSharedFromThis<ScriptEngineQtScript> {
46+ public std::enable_shared_from_this<ScriptEngineQtScript> {
4747 Q_OBJECT
4848
4949 public: // construction

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t