History

convert script engine variables from QSharedPointer to std::shared_ptr

Heather Anderson committed 5 years ago

Commit 70fbe761 parent 82535ca49 files · +194 −164Browse files

Showing the changes to assignment-client/src/scripts/EntityScriptServer.cpp (1 of 49 files). Show all

Unified · Split

assignment-client/src/scripts/EntityScriptServer.cpp+9−9
@@ -459,12 +459,12 @@ void EntityScriptServer::resetEntitiesScriptEngine() { · 458 unmodified lines
459459
460460 // connect this script engines printedMessage signal to the global ScriptEngines these various messages
461461 auto scriptEngines = DependencyManager::get<ScriptEngines>().data();
462− connect(newManager.data(), &ScriptManager::printedMessage, scriptEngines, &ScriptEngines::onPrintedMessage);
463− connect(newManager.data(), &ScriptManager::errorMessage, scriptEngines, &ScriptEngines::onErrorMessage);
464− connect(newManager.data(), &ScriptManager::warningMessage, scriptEngines, &ScriptEngines::onWarningMessage);
465− connect(newManager.data(), &ScriptManager::infoMessage, scriptEngines, &ScriptEngines::onInfoMessage);
462+ connect(newManager.get(), &ScriptManager::printedMessage, scriptEngines, &ScriptEngines::onPrintedMessage);
463+ connect(newManager.get(), &ScriptManager::errorMessage, scriptEngines, &ScriptEngines::onErrorMessage);
464+ connect(newManager.get(), &ScriptManager::warningMessage, scriptEngines, &ScriptEngines::onWarningMessage);
465+ connect(newManager.get(), &ScriptManager::infoMessage, scriptEngines, &ScriptEngines::onInfoMessage);
466466
467− connect(newManager.data(), &ScriptManager::update, this, [this] {
467+ connect(newManager.get(), &ScriptManager::update, this, [this] {
468468 _entityViewer.queryOctree();
469469 _entityViewer.getTree()->preUpdate();
470470 _entityViewer.getTree()->update();
@@ -472,18 +472,18 @@ void EntityScriptServer::resetEntitiesScriptEngine() { · 1 unmodified line
472472
473473 scriptEngines->runScriptInitializers(newManager);
474474 newManager->runInThread();
475− auto newEngineSP = qSharedPointerCast<EntitiesScriptEngineProvider>(newManager);
475+ std::shared_ptr<EntitiesScriptEngineProvider> newEngineSP = newManager;
476476 // On the entity script server, these are the same
477477 DependencyManager::get<EntityScriptingInterface>()->setPersistentEntitiesScriptEngine(newEngineSP);
478478 DependencyManager::get<EntityScriptingInterface>()->setNonPersistentEntitiesScriptEngine(newEngineSP);
479479
480480 if (_entitiesScriptManager) {
481− disconnect(_entitiesScriptManager.data(), &ScriptManager::entityScriptDetailsUpdated,
481+ disconnect(_entitiesScriptManager.get(), &ScriptManager::entityScriptDetailsUpdated,
482482 this, &EntityScriptServer::updateEntityPPS);
483483 }
484484
485485 _entitiesScriptManager.swap(newManager);
486− connect(_entitiesScriptManager.data(), &ScriptManager::entityScriptDetailsUpdated,
486+ connect(_entitiesScriptManager.get(), &ScriptManager::entityScriptDetailsUpdated,
487487 this, &EntityScriptServer::updateEntityPPS);
488488 }
489489
@@ -516,7 +516,7 @@ void EntityScriptServer::shutdownScriptEngine() { · 26 unmodified lines
516516 auto scriptEngines = DependencyManager::get<ScriptEngines>();
517517 scriptEngines->shutdownScripting();
518518
519− _entitiesScriptManager.clear();
519+ _entitiesScriptManager.reset();
520520
521521 auto entityScriptingInterface = DependencyManager::get<EntityScriptingInterface>();
522522 // our entity tree is going to go away so tell that to the EntityScriptingInterface