History

convert script engine variables from QSharedPointer to std::shared_ptr

Heather Anderson committed 5 years ago

Commit 70fbe761 parent 82535ca49 files · +194 −164Browse files

Showing the changes to libraries/entities/src/EntityScriptingInterface.cpp (1 of 49 files). Show all

Unified · Split

libraries/entities/src/EntityScriptingInterface.cpp+9−8
@@ -49,7 +49,7 @@ const QString GRABBABLE_USER_DATA = "{\"grabbableKey\":{\"grabbable\":true}}"; · 48 unmodified lines
4949 const QString NOT_GRABBABLE_USER_DATA = "{\"grabbableKey\":{\"grabbable\":false}}";
5050
5151 void staticEntityScriptInitializer(ScriptManager* manager) {
52− auto scriptEngine = manager->engine().data();
52+ auto scriptEngine = manager->engine().get();
5353
5454 auto entityScriptingInterface = DependencyManager::get<EntityScriptingInterface>();
5555 entityScriptingInterface->init();
@@ -145,7 +145,8 @@ void EntityScriptingInterface::attachDefaultEventHandlers(ScriptManager* manager · 89 unmodified lines
145145 using SingleEntityHandler = std::function<void(const EntityItemID&)>;
146146 auto makeSingleEntityHandler = [manager](QString eventName) -> SingleEntityHandler {
147147 return [manager, eventName](const EntityItemID& entityItemID) {
148− manager->forwardHandlerCall(entityItemID, eventName, { EntityItemIDtoScriptValue(manager->engine().data(), entityItemID) });
148+ manager->forwardHandlerCall(entityItemID, eventName,
149+ { EntityItemIDtoScriptValue(manager->engine().get(), entityItemID) });
149150 };
150151 };
151152
@@ -159,7 +160,7 @@ void EntityScriptingInterface::attachDefaultEventHandlers(ScriptManager* manager · 7 unmodified lines
159160 auto makePointerHandler = [manager](QString eventName) -> PointerHandler {
160161 return [manager, eventName](const EntityItemID& entityItemID, const PointerEvent& event) {
161162 if (!EntityTree::areEntityClicksCaptured()) {
162− ScriptEngine* engine = manager->engine().data();
163+ ScriptEngine* engine = manager->engine().get();
163164 manager->forwardHandlerCall(entityItemID, eventName,
164165 { EntityItemIDtoScriptValue(engine, entityItemID), event.toScriptValue(engine) });
165166 }
@@ -176,7 +177,7 @@ void EntityScriptingInterface::attachDefaultEventHandlers(ScriptManager* manager · 10 unmodified lines
176177 using CollisionHandler = std::function<void(const EntityItemID&, const EntityItemID&, const Collision&)>;
177178 auto makeCollisionHandler = [manager](QString eventName) -> CollisionHandler {
178179 return [manager, eventName](const EntityItemID& idA, const EntityItemID& idB, const Collision& collision) {
179− ScriptEngine* engine = manager->engine().data();
180+ ScriptEngine* engine = manager->engine().get();
180181 manager->forwardHandlerCall(idA, eventName,
181182 { EntityItemIDtoScriptValue(engine, idA),
182183 EntityItemIDtoScriptValue(engine, idB),
@@ -1234,12 +1235,12 @@ QSizeF EntityScriptingInterface::textSize(const QUuid& id, const QString& text) · 1051 unmodified lines
12341235 return EntityTree::textSize(id, text);
12351236 }
12361237
1237−void EntityScriptingInterface::setPersistentEntitiesScriptEngine(QSharedPointer<EntitiesScriptEngineProvider> manager) {
1238+void EntityScriptingInterface::setPersistentEntitiesScriptEngine(std::shared_ptr<EntitiesScriptEngineProvider> manager) {
12381239 std::lock_guard<std::recursive_mutex> lock(_entitiesScriptEngineLock);
12391240 _persistentEntitiesScriptManager = manager;
12401241 }
12411242
1242−void EntityScriptingInterface::setNonPersistentEntitiesScriptEngine(QSharedPointer<EntitiesScriptEngineProvider> manager) {
1243+void EntityScriptingInterface::setNonPersistentEntitiesScriptEngine(std::shared_ptr<EntitiesScriptEngineProvider> manager) {
12431244 std::lock_guard<std::recursive_mutex> lock(_entitiesScriptEngineLock);
12441245 _nonPersistentEntitiesScriptManager = manager;
12451246 }
@@ -1528,7 +1529,7 @@ bool EntityPropertyMetadataRequest::script(EntityItemID entityID, const ScriptVa · 282 unmodified lines
15281529 request->deleteLater();
15291530 });
15301531 auto entityScriptingInterface = DependencyManager::get<EntityScriptingInterface>();
1531− entityScriptingInterface->withEntitiesScriptEngine([&](QSharedPointer<EntitiesScriptEngineProvider> entitiesScriptEngine) {
1532+ entityScriptingInterface->withEntitiesScriptEngine([&](std::shared_ptr<EntitiesScriptEngineProvider> entitiesScriptEngine) {
15321533 if (entitiesScriptEngine) {
15331534 request->setFuture(entitiesScriptEngine->getLocalEntityScriptDetails(entityID));
15341535 }
@@ -2442,7 +2443,7 @@ void EntityScriptingInterface::getMeshes(const QUuid& entityID, const ScriptValu · 907 unmodified lines
24422443 bool success = entity->getMeshes(result);
24432444
24442445 if (success) {
2445− ScriptValue resultAsScriptValue = meshesToScriptValue(engine.data(), result);
2446+ ScriptValue resultAsScriptValue = meshesToScriptValue(engine.get(), result);
24462447 ScriptValueList args{ resultAsScriptValue, engine->newValue(true) };
24472448 callback.call(ScriptValue(), args);
24482449 } else {