Consider a NetworkClipLoader resource with null URL to be failed

Simon Walton committed 7 years ago

Commit 77017101 parent ff1d8282 files · +8 −2Browse files

Showing the changes to libraries/script-engine/src/RecordingScriptingInterface.cpp (1 of 2 files). Show all

Unified · Split

libraries/script-engine/src/RecordingScriptingInterface.cpp+1−1

@@ -93,7 +93,7 @@ void RecordingScriptingInterface::loadRecording(const QString& url, QScriptValue · 92 unmodified lines
93		93
94	// when clip load fails, call the callback with the URL and failure boolean	94	// when clip load fails, call the callback with the URL and failure boolean
95	connect(clipLoader.data(), &recording::NetworkClipLoader::failed, callback.engine(), [this, weakClipLoader, url, callback](QNetworkReply::NetworkError error) mutable {	95	connect(clipLoader.data(), &recording::NetworkClipLoader::failed, callback.engine(), [this, weakClipLoader, url, callback](QNetworkReply::NetworkError error) mutable {
96	qCDebug(scriptengine) << "Failed to load recording from" << url;	96	qCDebug(scriptengine) << "Failed to load recording from\"" << url << '"';
97		97
98	if (callback.isFunction()) {	98	if (callback.isFunction()) {
99	QScriptValueList args { false, url };	99	QScriptValueList args { false, url };