History

remove dead code

Brad Hefta-Gaub committed 10 years ago

Commit 770fab91 parent 95f7ea55 files · +1 −15Browse files

Unified · Split

5 files
  1. interface/src/Application.cpp +0 −4
  2. interface/src/Menu.cpp +0 −3
  3. interface/src/Menu.h +0 −1
  4. libraries/entities/src/EntityEditPacketSender.cpp +1 −3
  5. libraries/entities/src/EntityEditPacketSender.h +0 −4
interface/src/Application.cpp+0−4
@@ -3594,10 +3594,6 @@ void Application::update(float deltaTime) { · 3593 unmodified lines
35943594
35953595 int Application::sendNackPackets() {
35963596
3597− if (Menu::getInstance()->isOptionChecked(MenuOption::DisableNackPackets)) {
3598− return 0;
3599− }
3600−
36013597 // iterates through all nodes in NodeList
36023598 auto nodeList = DependencyManager::get<NodeList>();
36033599
interface/src/Menu.cpp+0−3
@@ -531,9 +531,6 @@ Menu::Menu() { · 530 unmodified lines
531531 // Developer > Network >>>
532532 MenuWrapper* networkMenu = developerMenu->addMenu("Network");
533533 addActionToQMenuAndActionHash(networkMenu, MenuOption::ReloadContent, 0, qApp, SLOT(reloadResourceCaches()));
534− addCheckableActionToQMenuAndActionHash(networkMenu, MenuOption::DisableNackPackets, 0, false,
535− qApp->getEntityEditPacketSender(),
536− SLOT(toggleNackPackets()));
537534 addCheckableActionToQMenuAndActionHash(networkMenu,
538535 MenuOption::DisableActivityLogger,
539536 0,
interface/src/Menu.h+0−1
@@ -84,7 +84,6 @@ namespace MenuOption { · 83 unmodified lines
8484 const QString DisableActivityLogger = "Disable Activity Logger";
8585 const QString DisableEyelidAdjustment = "Disable Eyelid Adjustment";
8686 const QString DisableLightEntities = "Disable Light Entities";
87− const QString DisableNackPackets = "Disable Entity NACK Packets";
8887 const QString DiskCacheEditor = "Disk Cache Editor";
8988 const QString DisplayCrashOptions = "Display Crash Options";
9089 const QString DisplayHandTargets = "Show Hand Targets";
libraries/entities/src/EntityEditPacketSender.cpp+1−3
@@ -24,9 +24,7 @@ EntityEditPacketSender::EntityEditPacketSender() { · 23 unmodified lines
2424 }
2525
2626 void EntityEditPacketSender::processEntityEditNackPacket(QSharedPointer<ReceivedMessage> message, SharedNodePointer sendingNode) {
27− if (_shouldProcessNack) {
28− processNackPacket(*message, sendingNode);
29− }
27+ processNackPacket(*message, sendingNode);
3028 }
3129
3230 void EntityEditPacketSender::adjustEditPacketForClockSkew(PacketType type, QByteArray& buffer, qint64 clockSkew) {
libraries/entities/src/EntityEditPacketSender.h+0−4
@@ -36,9 +36,5 @@ public: · 35 unmodified lines
3636
3737 public slots:
3838 void processEntityEditNackPacket(QSharedPointer<ReceivedMessage> message, SharedNodePointer sendingNode);
39− void toggleNackPackets() { _shouldProcessNack = !_shouldProcessNack; }
40−
41−private:
42− bool _shouldProcessNack = true;
4339 };
4440 #endif // hifi_EntityEditPacketSender_h