History

moving EntityItemID from script-engine to shared

Heather Anderson committed 5 years ago

Commit 7964f061 parent 665ea527 files · +80 −90Browse files

Showing the changes to libraries/entities/src/EntityScriptingInterface.cpp (1 of 7 files). Show all

Unified · Split

libraries/entities/src/EntityScriptingInterface.cpp+4−3
@@ -145,7 +145,7 @@ void EntityScriptingInterface::attachDefaultEventHandlers(ScriptManager* manager · 144 unmodified lines
145145 using SingleEntityHandler = std::function<void(const EntityItemID&)>;
146146 auto makeSingleEntityHandler = [manager](QString eventName) -> SingleEntityHandler {
147147 return [manager, eventName](const EntityItemID& entityItemID) {
148− manager->forwardHandlerCall(entityItemID, eventName, { entityItemID.toScriptValue(manager->engine().data()) });
148+ manager->forwardHandlerCall(entityItemID, eventName, { EntityItemIDtoScriptValue(manager->engine().data(), entityItemID) });
149149 };
150150 };
151151
@@ -161,7 +161,7 @@ void EntityScriptingInterface::attachDefaultEventHandlers(ScriptManager* manager · 9 unmodified lines
161161 if (!EntityTree::areEntityClicksCaptured()) {
162162 ScriptEngine* engine = manager->engine().data();
163163 manager->forwardHandlerCall(entityItemID, eventName,
164− { entityItemID.toScriptValue(engine), event.toScriptValue(engine) });
164+ { EntityItemIDtoScriptValue(engine, entityItemID), event.toScriptValue(engine) });
165165 }
166166 };
167167 };
@@ -178,7 +178,8 @@ void EntityScriptingInterface::attachDefaultEventHandlers(ScriptManager* manager · 10 unmodified lines
178178 return [manager, eventName](const EntityItemID& idA, const EntityItemID& idB, const Collision& collision) {
179179 ScriptEngine* engine = manager->engine().data();
180180 manager->forwardHandlerCall(idA, eventName,
181− { idA.toScriptValue(engine), idB.toScriptValue(engine),
181+ { EntityItemIDtoScriptValue(engine, idA),
182+ EntityItemIDtoScriptValue(engine, idB),
182183 collisionToScriptValue(engine, collision) });
183184 };
184185 };

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t