Removed cull functor from shadow render task as it is inadapted for the shadow's orthographic projection

Olivier Prat committed 9 years ago

Commit 79c2da31 parent fbcb2921 file · +4 −1Browse files

Showing the changes to libraries/render-utils/src/RenderViewTask.cpp (1 of 1 file). Show all

Unified · Split

libraries/render-utils/src/RenderViewTask.cpp+4−1

@@ -19,7 +19,10 @@ · 18 unmodified lines
19	19	void RenderViewTask::build(JobModel& task, const render::Varying& input, render::Varying& output, render::CullFunctor cullFunctor, bool isDeferred) {
20	20	// auto items = input.get<Input>();
21	21
22		− task.addJob<RenderShadowTask>("RenderShadowTask", cullFunctor);
	22	+ // Shadows use an orthographic projection because they are linked to sunlights
	23	+ // but the cullFunctor passed is probably tailored for perspective projection and culls too much.
	24	+ // TODO : create a special cull functor for this.
	25	+ task.addJob<RenderShadowTask>("RenderShadowTask", nullptr);
23	26
24	27	const auto items = task.addJob<RenderFetchCullSortTask>("FetchCullSort", cullFunctor);
25	28	assert(items.canCast<RenderFetchCullSortTask::Output>());