History

Apply my own comments

Sam Gateau committed 7 years ago

Commit 7f71ec81 parent ad60c513 files · +22 −23Browse files

Showing the changes to interface/src/RefreshRateManager.cpp (1 of 3 files). Show all

Unified · Split

interface/src/RefreshRateManager.cpp+15−11
@@ -26,24 +26,28 @@ static const std::array<std::string, RefreshRateManager::RefreshRateProfile::PRO · 25 unmodified lines
2626 { { "Eco", "Interactive", "Realtime" } };
2727
2828 static const std::array<std::string, RefreshRateManager::RefreshRateRegime::REGIME_NUM> REFRESH_RATE_REGIME_TO_STRING =
29− { { "Running", "Unfocus", "Minimized", "StartUp", "ShutDown", "Inactive" } };
29+ { { "FocusActive", "FocusInactive", "Unfocus", "Minimized", "StartUp", "ShutDown" } };
3030
3131 static const std::array<std::string, RefreshRateManager::UXMode::UX_NUM> UX_MODE_TO_STRING =
32− { { "Desktop", "HMD" } };
32+ { { "Desktop", "VR" } };
3333
3434 static const std::map<std::string, RefreshRateManager::RefreshRateProfile> REFRESH_RATE_PROFILE_FROM_STRING =
3535 { { "Eco", RefreshRateManager::RefreshRateProfile::ECO },
3636 { "Interactive", RefreshRateManager::RefreshRateProfile::INTERACTIVE },
3737 { "Realtime", RefreshRateManager::RefreshRateProfile::REALTIME } };
3838
39+
40+// Porfile regimes are:
41+// { { "Focus_Active", "Focus_Inactive", "Unfocus", "Minimized", "StartUp", "ShutDown" } }
42+
3943 static const std::array<int, RefreshRateManager::RefreshRateRegime::REGIME_NUM> ECO_PROFILE =
40− { { 5, 5, 2, 30, 30, 4 } };
44+ { { 15, 5, 5, 2, 30, 30 } };
4145
4246 static const std::array<int, RefreshRateManager::RefreshRateRegime::REGIME_NUM> INTERACTIVE_PROFILE =
43− { { 25, 5, 2, 30, 30, 20 } };
47+ { { 30, 20, 5, 2, 30, 30 } };
4448
4549 static const std::array<int, RefreshRateManager::RefreshRateRegime::REGIME_NUM> REALTIME_PROFILE =
46− { { 60, 10, 2, 30, 30, 30} };
50+ { { 60, 60, 10, 2, 30, 30} };
4751
4852 static const std::array<std::array<int, RefreshRateManager::RefreshRateRegime::REGIME_NUM>, RefreshRateManager::RefreshRateProfile::PROFILE_NUM> REFRESH_RATE_PROFILES =
4953 { { ECO_PROFILE, INTERACTIVE_PROFILE, REALTIME_PROFILE } };
@@ -74,8 +78,8 @@ RefreshRateManager::RefreshRateManager() { · 24 unmodified lines
7478 _inactiveTimer->setSingleShot(true);
7579 QObject::connect(_inactiveTimer.get(), &QTimer::timeout, [&] {
7680 if (_uxMode == RefreshRateManager::UXMode::DESKTOP &&
77− getRefreshRateRegime() == RefreshRateManager::RefreshRateRegime::RUNNING) {
78− setRefreshRateRegime(RefreshRateManager::RefreshRateRegime::INACTIVE);
81+ getRefreshRateRegime() == RefreshRateManager::RefreshRateRegime::FOCUS_ACTIVE) {
82+ setRefreshRateRegime(RefreshRateManager::RefreshRateRegime::FOCUS_INACTIVE);
7983 }
8084 });
8185 }
@@ -83,7 +87,7 @@ RefreshRateManager::RefreshRateManager() { · 1 unmodified line
8387 void RefreshRateManager::resetInactiveTimer() {
8488 if (_uxMode == RefreshRateManager::UXMode::DESKTOP) {
8589 _inactiveTimer->start();
86− setRefreshRateRegime(RefreshRateManager::RefreshRateRegime::RUNNING);
90+ setRefreshRateRegime(RefreshRateManager::RefreshRateRegime::FOCUS_ACTIVE);
8791 }
8892 }
8993
@@ -100,7 +104,7 @@ void RefreshRateManager::setRefreshRateProfile(RefreshRateManager::RefreshRatePr · 10 unmodified lines
100104 RefreshRateManager::RefreshRateProfile RefreshRateManager::getRefreshRateProfile() const {
101105 RefreshRateManager::RefreshRateProfile profile = RefreshRateManager::RefreshRateProfile::REALTIME;
102106
103− if (getUXMode() != RefreshRateManager::UXMode::HMD) {
107+ if (getUXMode() != RefreshRateManager::UXMode::VR) {
104108 profile =(RefreshRateManager::RefreshRateProfile) _refreshRateModeLock.resultWithReadLock<int>([&] {
105109 return _refreshRateMode.get();
106110 });
@@ -110,7 +114,7 @@ RefreshRateManager::RefreshRateProfile RefreshRateManager::getRefreshRateProfile · 3 unmodified lines
110114 }
111115
112116 RefreshRateManager::RefreshRateRegime RefreshRateManager::getRefreshRateRegime() const {
113− return getUXMode() == RefreshRateManager::UXMode::HMD ? RefreshRateManager::RefreshRateRegime::RUNNING :
117+ return getUXMode() == RefreshRateManager::UXMode::VR ? RefreshRateManager::RefreshRateRegime::FOCUS_ACTIVE :
114118 _refreshRateRegime;
115119 }
116120
@@ -133,7 +137,7 @@ void RefreshRateManager::updateRefreshRateController() const { · 16 unmodified lines
133137 if (_refreshRateOperator) {
134138 int targetRefreshRate;
135139 if (_uxMode == RefreshRateManager::UXMode::DESKTOP) {
136− if (_refreshRateRegime == RefreshRateManager::RefreshRateRegime::RUNNING &&
140+ if (_refreshRateRegime == RefreshRateManager::RefreshRateRegime::FOCUS_ACTIVE &&
137141 _refreshRateProfile == RefreshRateManager::RefreshRateProfile::INTERACTIVE) {
138142 targetRefreshRate = getInteractiveRefreshRate();
139143 } else {