History

more shifting around of ScriptEngineQtScript declaration

Heather Anderson committed 5 years ago

Commit 82535ca1 parent c9bf36e1 file · +9 −8Browse files

Showing the changes to libraries/script-engine/src/qtscript/ScriptEngineQtScript.h (1 of 1 file). Show all

Unified · Split

libraries/script-engine/src/qtscript/ScriptEngineQtScript.h+9−8
@@ -46,6 +46,14 @@ class ScriptEngineQtScript final : public QScriptEngine, · 45 unmodified lines
4646 public QEnableSharedFromThis<ScriptEngineQtScript> {
4747 Q_OBJECT
4848
49+public: // construction
50+ ScriptEngineQtScript(ScriptManager* scriptManager = nullptr);
51+ ~ScriptEngineQtScript();
52+
53+ ////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
54+ // NOTE - these are NOT intended to be public interfaces available to scripts, the are only Q_INVOKABLE so we can
55+ // properly ensure they are only called on the correct thread
56+
4957 public: // ScriptEngine implementation
5058 virtual void abortEvaluation() override;
5159 virtual void clearExceptions() override;
@@ -120,14 +128,7 @@ protected: // brought over from BaseScriptEngine · 68 unmodified lines
120128 // helper to detect and log warnings when other code invokes QScriptEngine/BaseScriptEngine in thread-unsafe ways
121129 static bool IS_THREADSAFE_INVOCATION(const QThread* thread, const QString& method);
122130
123−public:
124− ScriptEngineQtScript(ScriptManager* scriptManager = nullptr);
125− ~ScriptEngineQtScript();
126−
127− ////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
128− // NOTE - these are NOT intended to be public interfaces available to scripts, the are only Q_INVOKABLE so we can
129− // properly ensure they are only called on the correct thread
130−
131+public: // public non-interface methods for other QtScript-specific classes to use
131132 /// registers a global getter/setter
132133 Q_INVOKABLE void registerGetterSetter(const QString& name, QScriptEngine::FunctionSignature getter,
133134 QScriptEngine::FunctionSignature setter, const QString& parent = QString(""));

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t