History

rework ScriptValue to act like a stack variable rather than a pointer

Heather Anderson committed 5 years ago

Commit 85810221 parent f209c51170 files · +2837 −2594Browse files

Showing the changes to libraries/script-engine/src/qtscript/ScriptContextQtWrapper.cpp (1 of 170 files). Show all

Unified · Split

libraries/script-engine/src/qtscript/ScriptContextQtWrapper.cpp+10−10
@@ -28,18 +28,18 @@ int ScriptContextQtWrapper::argumentCount() const { · 27 unmodified lines
28 return _context->argumentCount();28 return _context->argumentCount();
29}29}
30 30
31ScriptValuePointer ScriptContextQtWrapper::argument(int index) const {31ScriptValue ScriptContextQtWrapper::argument(int index) const {
32 QScriptValue result = _context->argument(index);32 QScriptValue result = _context->argument(index);
33 return ScriptValuePointer(new ScriptValueQtWrapper(_engine, std::move(result)));33 return ScriptValue(new ScriptValueQtWrapper(_engine, std::move(result)));
34}34}
35 35
36QStringList ScriptContextQtWrapper::backtrace() const {36QStringList ScriptContextQtWrapper::backtrace() const {
37 return _context->backtrace();37 return _context->backtrace();
38}38}
39 39
40ScriptValuePointer ScriptContextQtWrapper::callee() const {40ScriptValue ScriptContextQtWrapper::callee() const {
41 QScriptValue result = _context->callee();41 QScriptValue result = _context->callee();
42 return ScriptValuePointer(new ScriptValueQtWrapper(_engine, std::move(result)));42 return ScriptValue(new ScriptValueQtWrapper(_engine, std::move(result)));
43}43}
44 44
45ScriptEnginePointer ScriptContextQtWrapper::engine() const {45ScriptEnginePointer ScriptContextQtWrapper::engine() const {
@@ -55,23 +55,23 @@ ScriptContextPointer ScriptContextQtWrapper::parentContext() const { · 9 unmodified lines
55 return result ? ScriptContextPointer(new ScriptContextQtWrapper(_engine, result)) : ScriptContextPointer();55 return result ? ScriptContextPointer(new ScriptContextQtWrapper(_engine, result)) : ScriptContextPointer();
56}56}
57 57
58ScriptValuePointer ScriptContextQtWrapper::thisObject() const {58ScriptValue ScriptContextQtWrapper::thisObject() const {
59 QScriptValue result = _context->thisObject();59 QScriptValue result = _context->thisObject();
60 return ScriptValuePointer(new ScriptValueQtWrapper(_engine, std::move(result)));60 return ScriptValue(new ScriptValueQtWrapper(_engine, std::move(result)));
61}61}
62 62
63ScriptValuePointer ScriptContextQtWrapper::throwError(const QString& text) {63ScriptValue ScriptContextQtWrapper::throwError(const QString& text) {
64 QScriptValue result = _context->throwError(text);64 QScriptValue result = _context->throwError(text);
65 return ScriptValuePointer(new ScriptValueQtWrapper(_engine, std::move(result)));65 return ScriptValue(new ScriptValueQtWrapper(_engine, std::move(result)));
66}66}
67 67
68ScriptValuePointer ScriptContextQtWrapper::throwValue(const ScriptValuePointer& value) {68ScriptValue ScriptContextQtWrapper::throwValue(const ScriptValue& value) {
69 ScriptValueQtWrapper* unwrapped = ScriptValueQtWrapper::unwrap(value);69 ScriptValueQtWrapper* unwrapped = ScriptValueQtWrapper::unwrap(value);
70 if (!unwrapped) {70 if (!unwrapped) {
71 return _engine->undefinedValue();71 return _engine->undefinedValue();
72 }72 }
73 QScriptValue result = _context->throwValue(unwrapped->toQtValue());73 QScriptValue result = _context->throwValue(unwrapped->toQtValue());
74 return ScriptValuePointer(new ScriptValueQtWrapper(_engine, std::move(result)));74 return ScriptValue(new ScriptValueQtWrapper(_engine, std::move(result)));
75}75}
76 76
77 77

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t