History

rework ScriptValue to act like a stack variable rather than a pointer

Heather Anderson committed 5 years ago

Commit 85810221 parent f209c51170 files · +2837 −2594Browse files

Showing the changes to libraries/script-engine/src/qtscript/ScriptContextQtWrapper.cpp (1 of 170 files). Show all

Unified · Split

libraries/script-engine/src/qtscript/ScriptContextQtWrapper.cpp+10−10
@@ -28,18 +28,18 @@ int ScriptContextQtWrapper::argumentCount() const { · 27 unmodified lines
2828 return _context->argumentCount();
2929 }
3030
31−ScriptValuePointer ScriptContextQtWrapper::argument(int index) const {
31+ScriptValue ScriptContextQtWrapper::argument(int index) const {
3232 QScriptValue result = _context->argument(index);
33− return ScriptValuePointer(new ScriptValueQtWrapper(_engine, std::move(result)));
33+ return ScriptValue(new ScriptValueQtWrapper(_engine, std::move(result)));
3434 }
3535
3636 QStringList ScriptContextQtWrapper::backtrace() const {
3737 return _context->backtrace();
3838 }
3939
40−ScriptValuePointer ScriptContextQtWrapper::callee() const {
40+ScriptValue ScriptContextQtWrapper::callee() const {
4141 QScriptValue result = _context->callee();
42− return ScriptValuePointer(new ScriptValueQtWrapper(_engine, std::move(result)));
42+ return ScriptValue(new ScriptValueQtWrapper(_engine, std::move(result)));
4343 }
4444
4545 ScriptEnginePointer ScriptContextQtWrapper::engine() const {
@@ -55,23 +55,23 @@ ScriptContextPointer ScriptContextQtWrapper::parentContext() const { · 9 unmodified lines
5555 return result ? ScriptContextPointer(new ScriptContextQtWrapper(_engine, result)) : ScriptContextPointer();
5656 }
5757
58−ScriptValuePointer ScriptContextQtWrapper::thisObject() const {
58+ScriptValue ScriptContextQtWrapper::thisObject() const {
5959 QScriptValue result = _context->thisObject();
60− return ScriptValuePointer(new ScriptValueQtWrapper(_engine, std::move(result)));
60+ return ScriptValue(new ScriptValueQtWrapper(_engine, std::move(result)));
6161 }
6262
63−ScriptValuePointer ScriptContextQtWrapper::throwError(const QString& text) {
63+ScriptValue ScriptContextQtWrapper::throwError(const QString& text) {
6464 QScriptValue result = _context->throwError(text);
65− return ScriptValuePointer(new ScriptValueQtWrapper(_engine, std::move(result)));
65+ return ScriptValue(new ScriptValueQtWrapper(_engine, std::move(result)));
6666 }
6767
68−ScriptValuePointer ScriptContextQtWrapper::throwValue(const ScriptValuePointer& value) {
68+ScriptValue ScriptContextQtWrapper::throwValue(const ScriptValue& value) {
6969 ScriptValueQtWrapper* unwrapped = ScriptValueQtWrapper::unwrap(value);
7070 if (!unwrapped) {
7171 return _engine->undefinedValue();
7272 }
7373 QScriptValue result = _context->throwValue(unwrapped->toQtValue());
74− return ScriptValuePointer(new ScriptValueQtWrapper(_engine, std::move(result)));
74+ return ScriptValue(new ScriptValueQtWrapper(_engine, std::move(result)));
7575 }
7676
7777

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t