History

rework ScriptValue to act like a stack variable rather than a pointer

Heather Anderson committed 5 years ago

Commit 85810221 parent f209c51170 files · +2837 −2594Browse files

Showing the changes to libraries/script-engine/src/VariantMapToScriptValue.cpp (1 of 170 files). Show all

Unified · Split

libraries/script-engine/src/VariantMapToScriptValue.cpp+8−8
@@ -15,7 +15,7 @@ · 14 unmodified lines
1515
1616 #include "SharedLogging.h"
1717
18−ScriptValuePointer variantToScriptValue(QVariant& qValue, ScriptEngine& scriptEngine) {
18+ScriptValue variantToScriptValue(QVariant& qValue, ScriptEngine& scriptEngine) {
1919 switch(qValue.type()) {
2020 case QVariant::Bool:
2121 return scriptEngine.newValue(qValue.toBool());
@@ -48,29 +48,29 @@ ScriptValuePointer variantToScriptValue(QVariant& qValue, ScriptEngine& scriptEn · 26 unmodified lines
4848 break;
4949 }
5050
51− return ScriptValuePointer();
51+ return ScriptValue();
5252 }
5353
5454
55−ScriptValuePointer variantMapToScriptValue(QVariantMap& variantMap, ScriptEngine& scriptEngine) {
56− ScriptValuePointer scriptValue = scriptEngine.newObject();
55+ScriptValue variantMapToScriptValue(QVariantMap& variantMap, ScriptEngine& scriptEngine) {
56+ ScriptValue scriptValue = scriptEngine.newObject();
5757
5858 for (QVariantMap::const_iterator iter = variantMap.begin(); iter != variantMap.end(); ++iter) {
5959 QString key = iter.key();
6060 QVariant qValue = iter.value();
61− scriptValue->setProperty(key, variantToScriptValue(qValue, scriptEngine));
61+ scriptValue.setProperty(key, variantToScriptValue(qValue, scriptEngine));
6262 }
6363
6464 return scriptValue;
6565 }
6666
6767
68−ScriptValuePointer variantListToScriptValue(QVariantList& variantList, ScriptEngine& scriptEngine) {
68+ScriptValue variantListToScriptValue(QVariantList& variantList, ScriptEngine& scriptEngine) {
6969
70− ScriptValuePointer scriptValue = scriptEngine.newArray();
70+ ScriptValue scriptValue = scriptEngine.newArray();
7171
7272 for (int i = 0; i < variantList.size(); i++) {
73− scriptValue->setProperty(i, variantToScriptValue(variantList[i], scriptEngine));
73+ scriptValue.setProperty(i, variantToScriptValue(variantList[i], scriptEngine));
7474 }
7575
7676 return scriptValue;