History

remove scale from ModelMeshPartPayload's transform

Andrew Meadows committed 9 years ago

Commit 87bdaae1 parent bd168241 file · +5 −3Browse files

Showing the changes to libraries/render-utils/src/Model.cpp (1 of 1 file). Show all

Unified · Split

libraries/render-utils/src/Model.cpp+5−3
@@ -216,10 +216,12 @@ void Model::updateRenderItems() { · 215 unmodified lines
216216 render::ScenePointer scene = AbstractViewStateInterface::instance()->getMain3DScene();
217217
218218 Transform modelTransform;
219− modelTransform.setScale(scale);
220219 modelTransform.setTranslation(self->_translation);
221220 modelTransform.setRotation(self->_rotation);
222221
222+ Transform scaledModelTransform(modelTransform);
223+ scaledModelTransform.setScale(scale);
224+
223225 Transform modelMeshOffset;
224226 if (self->isLoaded()) {
225227 // includes model offset and unitScale.
@@ -254,9 +256,9 @@ void Model::updateRenderItems() { · 28 unmodified lines
254256 Transform collisionMeshOffset;
255257 collisionMeshOffset.setIdentity();
256258 foreach (auto itemID, self->_collisionRenderItems.keys()) {
257− pendingChanges.updateItem<MeshPartPayload>(itemID, [modelTransform, collisionMeshOffset](MeshPartPayload& data) {
259+ pendingChanges.updateItem<MeshPartPayload>(itemID, [scaledModelTransform, collisionMeshOffset](MeshPartPayload& data) {
258260 // update the model transform for this render item.
259− data.updateTransform(modelTransform, collisionMeshOffset);
261+ data.updateTransform(scaledModelTransform, collisionMeshOffset);
260262 });
261263 }
262264

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t