History

add -Wsuggest-override to compile flags and deal with fallout

Seth Alves committed 10 years ago

Commit 87dbfa71 parent 89df576122 files · +768 −732Browse files

Showing the changes to libraries/script-engine/src/ArrayBufferClass.h (1 of 122 files). Show all

Unified · Split

libraries/script-engine/src/ArrayBufferClass.h+14−14
@@ -28,34 +28,34 @@ public: · 27 unmodified lines
28 ArrayBufferClass(ScriptEngine* scriptEngine);28 ArrayBufferClass(ScriptEngine* scriptEngine);
29 QScriptValue newInstance(qint32 size);29 QScriptValue newInstance(qint32 size);
30 QScriptValue newInstance(const QByteArray& ba);30 QScriptValue newInstance(const QByteArray& ba);
31 31
32 QueryFlags queryProperty(const QScriptValue& object,32 QueryFlags queryProperty(const QScriptValue& object,
33 const QScriptString& name,33 const QScriptString& name,
34 QueryFlags flags, uint* id);34 QueryFlags flags, uint* id) override;
35 QScriptValue property(const QScriptValue& object,35 QScriptValue property(const QScriptValue& object,
36 const QScriptString& name, uint id);36 const QScriptString& name, uint id) override;
37 QScriptValue::PropertyFlags propertyFlags(const QScriptValue& object,37 QScriptValue::PropertyFlags propertyFlags(const QScriptValue& object,
38 const QScriptString& name, uint id);38 const QScriptString& name, uint id) override;
39 39
40 QString name() const;40 QString name() const override;
41 QScriptValue prototype() const;41 QScriptValue prototype() const override;
42 42
43 ScriptEngine* getEngine() { return _scriptEngine; }43 ScriptEngine* getEngine() { return _scriptEngine; }
44 44
45private:45private:
46 static QScriptValue construct(QScriptContext* context, QScriptEngine* engine);46 static QScriptValue construct(QScriptContext* context, QScriptEngine* engine);
47 47
48 static QScriptValue toScriptValue(QScriptEngine* eng, const QByteArray& ba);48 static QScriptValue toScriptValue(QScriptEngine* eng, const QByteArray& ba);
49 static void fromScriptValue(const QScriptValue& obj, QByteArray& ba);49 static void fromScriptValue(const QScriptValue& obj, QByteArray& ba);
50 50
51 QScriptValue _proto;51 QScriptValue _proto;
52 QScriptValue _ctor;52 QScriptValue _ctor;
53 53
54 // JS Object attributes54 // JS Object attributes
55 QScriptString _name;55 QScriptString _name;
56 QScriptString _byteLength;56 QScriptString _byteLength;
57 57
58 ScriptEngine* _scriptEngine;58 ScriptEngine* _scriptEngine;
59};59};
60 60
61#endif // hifi_ArrayBufferClass_h61#endif // hifi_ArrayBufferClass_h