History

add -Wsuggest-override to compile flags and deal with fallout

Seth Alves committed 10 years ago

Commit 87dbfa71 parent 89df576122 files · +768 −732Browse files

Showing the changes to libraries/script-engine/src/ArrayBufferClass.h (1 of 122 files). Show all

Unified · Split

libraries/script-engine/src/ArrayBufferClass.h+14−14
@@ -28,34 +28,34 @@ public: · 27 unmodified lines
2828 ArrayBufferClass(ScriptEngine* scriptEngine);
2929 QScriptValue newInstance(qint32 size);
3030 QScriptValue newInstance(const QByteArray& ba);
31−
31+
3232 QueryFlags queryProperty(const QScriptValue& object,
3333 const QScriptString& name,
34− QueryFlags flags, uint* id);
34+ QueryFlags flags, uint* id) override;
3535 QScriptValue property(const QScriptValue& object,
36− const QScriptString& name, uint id);
36+ const QScriptString& name, uint id) override;
3737 QScriptValue::PropertyFlags propertyFlags(const QScriptValue& object,
38− const QScriptString& name, uint id);
39−
40− QString name() const;
41− QScriptValue prototype() const;
42−
38+ const QScriptString& name, uint id) override;
39+
40+ QString name() const override;
41+ QScriptValue prototype() const override;
42+
4343 ScriptEngine* getEngine() { return _scriptEngine; }
44−
44+
4545 private:
4646 static QScriptValue construct(QScriptContext* context, QScriptEngine* engine);
47−
47+
4848 static QScriptValue toScriptValue(QScriptEngine* eng, const QByteArray& ba);
4949 static void fromScriptValue(const QScriptValue& obj, QByteArray& ba);
50−
50+
5151 QScriptValue _proto;
5252 QScriptValue _ctor;
53−
53+
5454 // JS Object attributes
5555 QScriptString _name;
5656 QScriptString _byteLength;
57−
57+
5858 ScriptEngine* _scriptEngine;
5959 };
6060
61−#endif // hifi_ArrayBufferClass_h
61+#endif // hifi_ArrayBufferClass_h