Review fixes (non-working)

Trouble with: > Script.getExternalPath(Script.ExternalPaths.Assets, "hi") [UncaughtException evaluate] Error: cannot call getExternalPath(): argument 1 has unknown type `ExternalResource::Bucket' (register the type with qScriptRegisterMetaType()) in about:console:1 [Backtrace] <global>() at about:console:1 TypeError: cannot call getExternalPath(): argument 1 has unknown type `ExternalResource::Bucket' (register the type with qScriptRegisterMetaType())

Dale Glass committed 6 years ago

Commit 89aa89e1 parent 792854c6 files · +52 −28Browse files

Showing the changes to interface/src/scripting/ScreenshareScriptingInterface.cpp (1 of 6 files). Show all

Unified · Split

interface/src/scripting/ScreenshareScriptingInterface.cpp+1−1

@@ -129,7 +129,7 @@ static const uint8_t LOCAL_SCREENSHARE_WEB_ENTITY_FPS = 30; · 128 unmodified lines
129	// The `z` value here is dynamic.	129	// The `z` value here is dynamic.
130	static const glm::vec3 LOCAL_SCREENSHARE_WEB_ENTITY_LOCAL_POSITION(0.0128f, -0.0918f, 0.0f);	130	static const glm::vec3 LOCAL_SCREENSHARE_WEB_ENTITY_LOCAL_POSITION(0.0128f, -0.0918f, 0.0f);
131	static const glm::vec3 LOCAL_SCREENSHARE_WEB_ENTITY_DIMENSIONS(3.6790f, 2.0990f, 0.0100f);	131	static const glm::vec3 LOCAL_SCREENSHARE_WEB_ENTITY_DIMENSIONS(3.6790f, 2.0990f, 0.0100f);
132	static const QString LOCAL_SCREENSHARE_WEB_ENTITY_URL = ExternalResource::getInstance()->getUrl(ExternalResource::Bucket::Content,	132	static const QString LOCAL_SCREENSHARE_WEB_ENTITY_URL = ExternalResource::getInstance()->getUrl(ExternalResource::Bucket::HF_Content,
133	"Experiences/Releases/usefulUtilities/smartBoard/screenshareViewer/screenshareClient.html");	133	"Experiences/Releases/usefulUtilities/smartBoard/screenshareViewer/screenshareClient.html");
134	static const QString LOCAL_SCREENSHARE_WEB_ENTITY_HOST_TYPE = "local";	134	static const QString LOCAL_SCREENSHARE_WEB_ENTITY_HOST_TYPE = "local";
135	void ScreenshareScriptingInterface::startScreenshare(const QUuid& screenshareZoneID,	135	void ScreenshareScriptingInterface::startScreenshare(const QUuid& screenshareZoneID,