History

code review

Seth Alves committed 9 years ago

Commit 8a49edb1 parent cf2979d16 files · +54 −51Browse files

Showing the changes to libraries/script-engine/src/ScriptEngine.cpp (1 of 16 files). Show all

Unified · Split

libraries/script-engine/src/ScriptEngine.cpp+3−3
@@ -153,11 +153,11 @@ QString ScriptEngine::logException(const QScriptValue& exception) { · 152 unmodified lines
153153 return message;
154154 }
155155
156−QSharedPointer<ScriptEngine> scriptEngineFactory(ScriptEngine::Context context,
156+ScriptEnginePointer scriptEngineFactory(ScriptEngine::Context context,
157157 const QString& scriptContents,
158158 const QString& fileNameString) {
159159 ScriptEngine* engine = new ScriptEngine(context, scriptContents, fileNameString);
160− QSharedPointer<ScriptEngine> engineSP = QSharedPointer<ScriptEngine>(engine);
160+ ScriptEnginePointer engineSP = ScriptEnginePointer(engine);
161161 DependencyManager::get<ScriptEngines>()->addScriptEngine(qSharedPointerCast<ScriptEngine>(engineSP));
162162 return engineSP;
163163 }
@@ -537,7 +537,7 @@ static void scriptableResourceFromScriptValue(const QScriptValue& value, Scripta · 373 unmodified lines
537537 resource = static_cast<ScriptableResourceRawPtr>(value.toQObject());
538538 }
539539
540−static QScriptValue createScriptableResourcePrototype(QSharedPointer<ScriptEngine> engine) {
540+static QScriptValue createScriptableResourcePrototype(ScriptEnginePointer engine) {
541541 auto prototype = engine->newObject();
542542
543543 // Expose enum State to JS/QML via properties