History

Fix script error logging

ksuprynowicz committed 3 years ago

Commit 8dc776a1 parent 3164e715 files · +44 −14Browse files

Showing the changes to libraries/script-engine/src/v8/ScriptObjectV8Proxy.cpp (1 of 5 files). Show all

Unified · Split

libraries/script-engine/src/v8/ScriptObjectV8Proxy.cpp+8−3
@@ -1255,9 +1255,14 @@ int ScriptSignalV8Proxy::qt_metacall(QMetaObject::Call call, int id, void** argu · 1254 unmodified lines
12551255 v8::TryCatch tryCatch(isolate);
12561256 callback->Call(functionContext, v8This, numArgs, args);
12571257 if (tryCatch.HasCaught()) {
1258− qCDebug(scriptengine) << "Signal proxy " << fullName() << " connection call failed: \""
1259− << _engine->formatErrorMessageFromTryCatch(tryCatch)
1260− << "\nThis provided: " << conn.thisValue.get()->IsObject();
1258+ QString errorMessage(QString("Signal proxy ") + fullName() + " connection call failed: \""
1259+ + _engine->formatErrorMessageFromTryCatch(tryCatch)
1260+ + "\nThis provided: " + QString::number(conn.thisValue.get()->IsObject()));
1261+ if (_engine->_manager) {
1262+ _engine->_manager->scriptErrorMessage(errorMessage);
1263+ } else {
1264+ qDebug(scriptengine_v8) << errorMessage;
1265+ }
12611266
12621267 _engine->setUncaughtException(tryCatch, "Error in signal proxy");
12631268 }