History

V8 related cleanup

ksuprynowicz committed 3 years ago

Commit 8de13311 parent fe9babf5 files · +9 −28Browse files

Showing the changes to libraries/script-engine/src/MenuItemProperties.cpp (1 of 5 files). Show all

Unified · Split

libraries/script-engine/src/MenuItemProperties.cpp+6−0
@@ -78,6 +78,12 @@ ScriptValue menuItemPropertiesToScriptValue(ScriptEngine* engine, const MenuItem · 77 unmodified lines
7878 * @property {string} [grouping] - The name of grouping to add this menu item to.
7979 */
8080 bool menuItemPropertiesFromScriptValue(const ScriptValue& object, MenuItemProperties& properties) {
81+ if (!object.hasProperty("menuName")) {
82+ return false;
83+ }
84+ if (!object.hasProperty("menuItemName")) {
85+ return false;
86+ }
8187 properties.menuName = object.property("menuName").toVariant().toString();
8288 properties.menuItemName = object.property("menuItemName").toVariant().toString();
8389 properties.isCheckable = object.property("isCheckable").toVariant().toBool();

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t