History

Merge pull request #5371 from Atlante45/smart_pointers

Smart pointers fixes

Brad Davis committed 11 years ago

Commit 9016f432 parents 5b63863 8d6ff2d61 files · +316 −320Browse files

Showing the changes to interface/src/Application.cpp (1 of 61 files). Show all

Unified · Split

interface/src/Application.cpp+8−8
@@ -363,7 +363,7 @@ Application::Application(int& argc, char** argv, QElapsedTimer &startup_time) : · 362 unmodified lines
363363 _bookmarks = new Bookmarks(); // Before setting up the menu
364364
365365 _runningScriptsWidget = new RunningScriptsWidget(_window);
366− _renderEngine->addTask(render::TaskPointer(new RenderDeferredTask()));
366+ _renderEngine->addTask(make_shared<RenderDeferredTask>());
367367 _renderEngine->registerScene(_main3DScene);
368368
369369 // start the nodeThread so its event loop is running
@@ -2231,8 +2231,8 @@ void Application::shrinkMirrorView() { · 1861 unmodified lines
22312231
22322232 const float HEAD_SPHERE_RADIUS = 0.1f;
22332233
2234−bool Application::isLookingAtMyAvatar(Avatar* avatar) {
2235− glm::vec3 theirLookAt = avatar->getHead()->getLookAtPosition();
2234+bool Application::isLookingAtMyAvatar(AvatarSharedPointer avatar) {
2235+ glm::vec3 theirLookAt = dynamic_pointer_cast<Avatar>(avatar)->getHead()->getLookAtPosition();
22362236 glm::vec3 myEyePosition = _myAvatar->getHead()->getEyePosition();
22372237 if (pointInSphere(theirLookAt, myEyePosition, HEAD_SPHERE_RADIUS * _myAvatar->getScale())) {
22382238 return true;
@@ -2296,7 +2296,7 @@ void Application::updateMyAvatarLookAtPosition() { · 57 unmodified lines
22962296 if (lookingAt && _myAvatar != lookingAt.get()) {
22972297 // If I am looking at someone else, look directly at one of their eyes
22982298 isLookingAtSomeone = true;
2299− Head* lookingAtHead = static_cast<Avatar*>(lookingAt.get())->getHead();
2299+ auto lookingAtHead = static_pointer_cast<Avatar>(lookingAt)->getHead();
23002300
23012301 const float MAXIMUM_FACE_ANGLE = 65.0f * RADIANS_PER_DEGREE;
23022302 glm::vec3 lookingAtFaceOrientation = lookingAtHead->getFinalOrientationInWorldFrame() * IDENTITY_FRONT;
@@ -3202,8 +3202,8 @@ void Application::displaySide(RenderArgs* renderArgs, Camera& theCamera, bool se · 899 unmodified lines
32023202
32033203 // Background rendering decision
32043204 if (BackgroundRenderData::_item == 0) {
3205− auto backgroundRenderData = BackgroundRenderData::Pointer(new BackgroundRenderData(&_environment));
3206− auto backgroundRenderPayload = render::PayloadPointer(new BackgroundRenderData::Payload(backgroundRenderData));
3205+ auto backgroundRenderData = make_shared<BackgroundRenderData>(&_environment);
3206+ auto backgroundRenderPayload = make_shared<BackgroundRenderData::Payload>(backgroundRenderData);
32073207 BackgroundRenderData::_item = _main3DScene->allocateID();
32083208 pendingChanges.resetItem(WorldBoxRenderData::_item, backgroundRenderPayload);
32093209 } else {
@@ -3234,8 +3234,8 @@ void Application::displaySide(RenderArgs* renderArgs, Camera& theCamera, bool se · 24 unmodified lines
32343234
32353235 // Make sure the WorldBox is in the scene
32363236 if (WorldBoxRenderData::_item == 0) {
3237− auto worldBoxRenderData = WorldBoxRenderData::Pointer(new WorldBoxRenderData());
3238− auto worldBoxRenderPayload = render::PayloadPointer(new WorldBoxRenderData::Payload(worldBoxRenderData));
3237+ auto worldBoxRenderData = make_shared<WorldBoxRenderData>();
3238+ auto worldBoxRenderPayload = make_shared<WorldBoxRenderData::Payload>(worldBoxRenderData);
32393239
32403240 WorldBoxRenderData::_item = _main3DScene->allocateID();
32413241

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t