History

Avoid warnings on invalid URLs, delete reply when reference is deleted.

Andrzej Kapolka committed 13 years ago

Commit 97cbef11 parent 40a32684 files · +19 −3Browse files

Showing the changes to interface/src/renderer/GeometryCache.cpp (1 of 4 files). Show all

Unified · Split

interface/src/renderer/GeometryCache.cpp+7−1
@@ -250,7 +250,10 @@ QSharedPointer<NetworkGeometry> GeometryCache::getGeometry(const QUrl& url) { · 249 unmodified lines
250250 return geometry;
251251 }
252252
253−NetworkGeometry::NetworkGeometry(const QUrl& url) {
253+NetworkGeometry::NetworkGeometry(const QUrl& url) : _reply(NULL) {
254+ if (!url.isValid()) {
255+ return;
256+ }
254257 QNetworkRequest request(url);
255258 request.setAttribute(QNetworkRequest::CacheLoadControlAttribute, QNetworkRequest::PreferCache);
256259 _reply = Application::getInstance()->getNetworkAccessManager()->get(request);
@@ -260,6 +263,9 @@ NetworkGeometry::NetworkGeometry(const QUrl& url) { · 3 unmodified lines
260263 }
261264
262265 NetworkGeometry::~NetworkGeometry() {
266+ if (_reply != NULL) {
267+ delete _reply;
268+ }
263269 foreach (const NetworkMesh& mesh, _meshes) {
264270 glDeleteBuffers(1, &mesh.indexBufferID);
265271 glDeleteBuffers(1, &mesh.vertexBufferID);

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t