History

Fix accumulating signal connections

David Rowe committed 9 years ago

Commit 98c1a181 parent a0834791 file · +5 −5Browse files

Showing the changes to libraries/script-engine/src/TabletScriptingInterface.cpp (1 of 1 file). Show all

Unified · Split

libraries/script-engine/src/TabletScriptingInterface.cpp+5−5
@@ -368,13 +368,13 @@ void TabletProxy::addButtonsToMenuScreen() { · 367 unmodified lines
368368 }
369369
370370 QQuickItem* VrMenu = loader->findChild<QQuickItem*>("tabletMenu");
371− if (!VrMenu) {
372− return;
371+ if (VrMenu) {
372+ auto offscreenUi = DependencyManager::get<OffscreenUi>();
373+ QObject* menu = offscreenUi->getRootMenu();
374+ QMetaObject::invokeMethod(VrMenu, "setRootMenu", Qt::AutoConnection, Q_ARG(QVariant, QVariant::fromValue(menu)));
373375 }
374376
375− auto offscreenUi = DependencyManager::get<OffscreenUi>();
376− QObject* menu = offscreenUi->getRootMenu();
377− QMetaObject::invokeMethod(VrMenu, "setRootMenu", Qt::AutoConnection, Q_ARG(QVariant, QVariant::fromValue(menu)));
377+ QObject::disconnect(loader, SIGNAL(loaded()), this, SLOT(addButtonsToMenuScreen()));
378378 }
379379
380380 void TabletProxy::removeButtonsFromHomeScreen() {