History

fix URL/filename discrepancy for local scripts

Stephen Birarda committed 11 years ago

Commit 98f56aa1 parent a549b4b4 files · +20 −21Browse files

Showing the changes to libraries/script-engine/src/ScriptEngine.cpp (1 of 4 files). Show all

Unified · Split

libraries/script-engine/src/ScriptEngine.cpp+11−12
@@ -156,31 +156,30 @@ void ScriptEngine::loadURL(const QUrl& scriptURL) { · 155 unmodified lines
156156 if (_isRunning) {
157157 return;
158158 }
159−
160− QString scriptURLString = scriptURL.toString();
161− _fileNameString = scriptURLString;
159+
160+ _fileNameString = scriptURL.toString();
162161
163162 QUrl url(scriptURL);
164163
165164 // if the scheme length is one or lower, maybe they typed in a file, let's try
166165 const int WINDOWS_DRIVE_LETTER_SIZE = 1;
167166 if (url.scheme().size() <= WINDOWS_DRIVE_LETTER_SIZE) {
168− url = QUrl::fromLocalFile(scriptURLString);
167+ url = QUrl::fromLocalFile(_fileNameString);
169168 }
170169
171170 // ok, let's see if it's valid... and if so, load it
172171 if (url.isValid()) {
173172 if (url.scheme() == "file") {
174− QString fileName = url.toLocalFile();
175− QFile scriptFile(fileName);
173+ _fileNameString = url.toLocalFile();
174+ QFile scriptFile(_fileNameString);
176175 if (scriptFile.open(QFile::ReadOnly | QFile::Text)) {
177− qDebug() << "Loading file:" << fileName;
176+ qDebug() << "ScriptEngine loading file:" << _fileNameString;
178177 QTextStream in(&scriptFile);
179178 _scriptContents = in.readAll();
180− emit scriptLoaded(url);
179+ emit scriptLoaded(_fileNameString);
181180 } else {
182− qDebug() << "ERROR Loading file:" << fileName;
183− emit errorLoadingScript(url);
181+ qDebug() << "ERROR Loading file:" << _fileNameString;
182+ emit errorLoadingScript(_fileNameString);
184183 }
185184 } else {
186185 QNetworkAccessManager& networkAccessManager = NetworkAccessManager::getInstance();
@@ -195,10 +194,10 @@ void ScriptEngine::handleScriptDownload() { · 8 unmodified lines
195194
196195 if (reply->error() == QNetworkReply::NoError && reply->attribute(QNetworkRequest::HttpStatusCodeAttribute) == 200) {
197196 _scriptContents = reply->readAll();
198− emit scriptLoaded(reply->url());
197+ emit scriptLoaded(_fileNameString);
199198 } else {
200199 qDebug() << "ERROR Loading file:" << reply->url().toString();
201− emit errorLoadingScript(reply->url());
200+ emit errorLoadingScript(_fileNameString);
202201 }
203202 }
204203