History

Don't display domain login status in title bar unless relevant

David Rowe committed 6 years ago

Commit 9bb5add1 parent c9c8e5f5 files · +105 −44Browse files

Showing the changes to interface/src/Application.cpp (1 of 5 files). Show all

Unified · Split

interface/src/Application.cpp+15−11
@@ -1352,10 +1352,10 @@ Application::Application(int& argc, char** argv, QElapsedTimer& startupTimer, bo · 1351 unmodified lines
13521352 connect(accountManager.data(), &AccountManager::usernameChanged, this, &Application::updateWindowTitle);
13531353
13541354 auto domainAccountManager = DependencyManager::get<DomainAccountManager>();
1355− connect(domainAccountManager.data(), &DomainAccountManager::authRequired, dialogsManager.data(),
1356− &DialogsManager::showDomainLoginDialog);
1357− connect(domainAccountManager.data(), &DomainAccountManager::loginComplete, this,
1358− &Application::updateWindowTitle);
1355+ connect(domainAccountManager.data(), &DomainAccountManager::authRequired,
1356+ dialogsManager.data(), &DialogsManager::showDomainLoginDialog);
1357+ connect(domainAccountManager.data(), &DomainAccountManager::authRequired, this, &Application::updateWindowTitle);
1358+ connect(domainAccountManager.data(), &DomainAccountManager::loginComplete, this, &Application::updateWindowTitle);
13591359 // ####### TODO: Connect any other signals from domainAccountManager.
13601360
13611361 // use our MyAvatar position and quat for address manager path
@@ -7084,6 +7084,7 @@ void Application::updateWindowTitle() const { · 5722 unmodified lines
70847084 auto domainAccountManager = DependencyManager::get<DomainAccountManager>();
70857085 auto isInErrorState = nodeList->getDomainHandler().isInErrorState();
70867086 bool isMetaverseLoggedIn = accountManager->isLoggedIn();
7087+ bool hasDomainLogIn = domainAccountManager->hasLogIn();
70877088 bool isDomainLoggedIn = domainAccountManager->isLoggedIn();
70887089 QString authedDomain = domainAccountManager->getAuthedDomain();
70897090
@@ -7115,20 +7116,23 @@ void Application::updateWindowTitle() const { · 25 unmodified lines
71157116
71167117 QString metaverseDetails;
71177118 if (isMetaverseLoggedIn) {
7118− metaverseDetails = "Metaverse: Logged in as " + metaverseUsername;
7119+ metaverseDetails = " (Metaverse: Logged in as " + metaverseUsername + ")";
71197120 } else {
7120− metaverseDetails = "Metaverse: Not Logged In";
7121+ metaverseDetails = " (Metaverse: Not Logged In)";
71217122 }
71227123
71237124 QString domainDetails;
7124− if (currentPlaceName == authedDomain && isDomainLoggedIn) {
7125− domainDetails = "Domain: Logged in as " + domainUsername;
7125+ if (hasDomainLogIn) {
7126+ if (currentPlaceName == authedDomain && isDomainLoggedIn) {
7127+ domainDetails = " (Domain: Logged in as " + domainUsername + ")";
7128+ } else {
7129+ domainDetails = " (Domain: Not Logged In)";
7130+ }
71267131 } else {
7127− domainDetails = "Domain: Not Logged In";
7132+ domainDetails = "";
71287133 }
71297134
7130− QString title = QString() + currentPlaceName + connectionStatus + " (" + metaverseDetails + ") (" + domainDetails + ")"
7131− + buildVersion;
7135+ QString title = currentPlaceName + connectionStatus + metaverseDetails + domainDetails + buildVersion;
71327136
71337137 #ifndef WIN32
71347138 // crashes with vs2013/win32