History

INtroduce range check for int value against the several enums we exposed through the js api for REnder and PErformance settings

Sam Gateau committed 7 years ago

Commit 9bc6c3b1 parent 34bae256 files · +10 −5Browse files

Showing the changes to interface/src/RefreshRateManager.cpp (1 of 6 files). Show all

Unified · Split

interface/src/RefreshRateManager.cpp+3−3
@@ -94,7 +94,7 @@ void RefreshRateManager::toggleInactive() { · 93 unmodified lines
9494 }
9595
9696 void RefreshRateManager::setRefreshRateProfile(RefreshRateManager::RefreshRateProfile refreshRateProfile) {
97− if (_refreshRateProfile != refreshRateProfile) {
97+ if (isValidRefreshRateProfile(refreshRateProfile) && (_refreshRateProfile != refreshRateProfile)) {
9898 _refreshRateProfileSettingLock.withWriteLock([&] {
9999 _refreshRateProfile = refreshRateProfile;
100100 _refreshRateProfileSetting.set((int) refreshRateProfile);
@@ -124,7 +124,7 @@ RefreshRateManager::RefreshRateRegime RefreshRateManager::getRefreshRateRegime() · 23 unmodified lines
124124 }
125125
126126 void RefreshRateManager::setRefreshRateRegime(RefreshRateManager::RefreshRateRegime refreshRateRegime) {
127− if (_refreshRateRegime != refreshRateRegime) {
127+ if (isValidRefreshRateRegime(refreshRateRegime) && (_refreshRateRegime != refreshRateRegime)) {
128128 _refreshRateRegime = refreshRateRegime;
129129 updateRefreshRateController();
130130 }
@@ -132,7 +132,7 @@ void RefreshRateManager::setRefreshRateRegime(RefreshRateManager::RefreshRateReg · 1 unmodified line
132132 }
133133
134134 void RefreshRateManager::setUXMode(RefreshRateManager::UXMode uxMode) {
135− if (_uxMode != uxMode) {
135+ if (isValidUXMode(uxMode) && (_uxMode != uxMode)) {
136136 _uxMode = uxMode;
137137 updateRefreshRateController();
138138 }

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t