History

- remove webSockets from List after disconnect. - leave it up to the QtScript to delete the WebSocket / WebSocketServer objects

Thijs Wenker committed 11 years ago

Commit 9edba451 parent f5122053 files · +8 −7Browse files

Showing the changes to libraries/script-engine/src/WebSocketClass.cpp (1 of 3 files). Show all

Unified · Split

libraries/script-engine/src/WebSocketClass.cpp+2−4
@@ -42,9 +42,7 @@ QScriptValue WebSocketClass::constructor(QScriptContext* context, QScriptEngine* · 41 unmodified lines
4242 if (context->argumentCount() > 0) {
4343 url = context->argument(0).toString();
4444 }
45− auto webSocketClass = new WebSocketClass(engine, url);
46− connect(static_cast<ScriptEngine*>(engine), &ScriptEngine::finished, webSocketClass, &QObject::deleteLater);
47− return engine->newQObject(webSocketClass);
45+ return engine->newQObject(new WebSocketClass(engine, url), QScriptEngine::ScriptOwnership);
4846 }
4947
5048 WebSocketClass::~WebSocketClass() {
@@ -111,7 +109,7 @@ void qWSCloseCodeFromScriptValue(const QScriptValue &object, QWebSocketProtocol: · 60 unmodified lines
111109 }
112110
113111 QScriptValue webSocketToScriptValue(QScriptEngine* engine, WebSocketClass* const &in) {
114− return engine->newQObject(in);
112+ return engine->newQObject(in, QScriptEngine::ScriptOwnership);
115113 }
116114
117115 void webSocketFromScriptValue(const QScriptValue &object, WebSocketClass* &out) {