Impelement settingChanged; clean up some emoteIndicatorVisible code

Zach Fox committed 7 years ago

Commit a053f9e1 parent 98eff6e4 files · +51 −35Browse files

Showing the changes to interface/src/scripting/SettingsScriptingInterface.cpp (1 of 4 files). Show all

Unified · Split

@@ -35,8 +35,12 @@ QVariant SettingsScriptingInterface::getValue(const QString& setting, const QVar · 34 unmodified lines
35	35	}
36	36
37	37	void SettingsScriptingInterface::setValue(const QString& setting, const QVariant& value) {
	38	+ if (getValue(setting) == value) {
	39	+ return;
	40	+ }
38	41	// Make a deep-copy of the string.
39	42	// Dangling pointers can occur with QStrings that are implicitly shared from a QScriptEngine.
40	43	QString deepCopy = QString::fromUtf16(setting.utf16());
41	44	Setting::Handle<QVariant>(deepCopy).set(value);
	45	+ emit valueChanged(setting, value);
42	46	}