History

clean up reticle scripting to be exposed through Reticle object (implemented int ApplicationCompositor)

Brad Hefta-Gaub committed 10 years ago

Commit a25581c1 parent 0d873c712 files · +92 −141Browse files

Showing the changes to interface/src/Application.cpp (1 of 12 files). Show all

Unified · Split

interface/src/Application.cpp+14−12
@@ -806,14 +806,14 @@ Application::Application(int& argc, char** argv, QElapsedTimer& startupTimer) : · 805 unmodified lines
806806 } else if (action == controller::toInt(controller::Action::CYCLE_CAMERA)) {
807807 cycleCamera();
808808 } else if (action == controller::toInt(controller::Action::CONTEXT_MENU)) {
809− auto reticlePosition = _controllerScriptingInterface->getReticlePosition();
809+ auto reticlePosition = _compositor.getReticlePosition();
810810 offscreenUi->toggleMenu(_glWidget->mapFromGlobal(QPoint(reticlePosition.x, reticlePosition.y)));
811811 } else if (action == controller::toInt(controller::Action::RETICLE_X)) {
812− auto oldPos = _controllerScriptingInterface->getReticlePosition();
813− _controllerScriptingInterface->setReticlePosition({ oldPos.x + state, oldPos.y });
812+ auto oldPos = _compositor.getReticlePosition();
813+ _compositor.setReticlePosition({ oldPos.x + state, oldPos.y });
814814 } else if (action == controller::toInt(controller::Action::RETICLE_Y)) {
815− auto oldPos = _controllerScriptingInterface->getReticlePosition();
816− _controllerScriptingInterface->setReticlePosition({ oldPos.x, oldPos.y + state });
815+ auto oldPos = _compositor.getReticlePosition();
816+ _compositor.setReticlePosition({ oldPos.x, oldPos.y + state });
817817 }
818818 }
819819 });
@@ -1254,6 +1254,7 @@ void Application::initializeUi() { · 434 unmodified lines
12541254 rootContext->setContextProperty("HMD", DependencyManager::get<HMDScriptingInterface>().data());
12551255 rootContext->setContextProperty("Scene", DependencyManager::get<SceneScriptingInterface>().data());
12561256 rootContext->setContextProperty("Render", _renderEngine->getConfiguration().get());
1257+ rootContext->setContextProperty("Reticle", _compositor.getReticleInterface());
12571258
12581259 _glWidget->installEventFilter(offscreenUi.data());
12591260 offscreenUi->setMouseTranslator([=](const QPointF& pt) {
@@ -2085,7 +2086,7 @@ void Application::keyPressEvent(QKeyEvent* event) { · 825 unmodified lines
20852086 void Application::keyReleaseEvent(QKeyEvent* event) {
20862087 if (event->key() == Qt::Key_Alt && _altPressed && hasFocus()) {
20872088 auto offscreenUi = DependencyManager::get<OffscreenUi>();
2088− auto reticlePosition = _controllerScriptingInterface->getReticlePosition();
2089+ auto reticlePosition = _compositor.getReticlePosition();
20892090 offscreenUi->toggleMenu(_glWidget->mapFromGlobal(QPoint(reticlePosition.x, reticlePosition.y)));
20902091 }
20912092
@@ -2542,7 +2543,7 @@ void Application::setLowVelocityFilter(bool lowVelocityFilter) { · 450 unmodified lines
25422543 controller::InputDevice::setLowVelocityFilter(lowVelocityFilter);
25432544 }
25442545
2545−ivec2 Application::getMouse() const {
2546+ivec2 Application::getMouse() {
25462547 if (isHMDMode()) {
25472548 return _compositor.screenToOverlay(getTrueMouse());
25482549 }
@@ -3566,7 +3567,7 @@ glm::vec3 Application::getSunDirection() { · 1017 unmodified lines
35663567 // FIXME, preprocessor guard this check to occur only in DEBUG builds
35673568 static QThread * activeRenderingThread = nullptr;
35683569
3569−PickRay Application::computePickRay(float x, float y) const {
3570+PickRay Application::computePickRay(float x, float y) {
35703571 vec2 pickPoint { x, y };
35713572 PickRay result;
35723573 if (isHMDMode()) {
@@ -4216,6 +4217,7 @@ void Application::registerScriptEngineWithApplicationServices(ScriptEngine* scri · 643 unmodified lines
42164217 scriptEngine->registerGlobalObject("Render", _renderEngine->getConfiguration().get());
42174218
42184219 scriptEngine->registerGlobalObject("ScriptDiscoveryService", DependencyManager::get<ScriptEngines>().data());
4220+ scriptEngine->registerGlobalObject("Reticle", _compositor.getReticleInterface());
42194221 }
42204222
42214223 bool Application::canAcceptURL(const QString& urlString) const {
@@ -4695,7 +4697,7 @@ QSize Application::getDeviceSize() const { · 473 unmodified lines
46954697 return fromGlm(getActiveDisplayPlugin()->getRecommendedRenderSize());
46964698 }
46974699
4698−PickRay Application::computePickRay() const {
4700+PickRay Application::computePickRay() {
46994701 return computePickRay(getTrueMouse().x, getTrueMouse().y);
47004702 }
47014703
@@ -4703,9 +4705,9 @@ bool Application::isThrottleRendering() const { · 1 unmodified line
47034705 return getActiveDisplayPlugin()->isThrottled();
47044706 }
47054707
4706−// FIXME -- consolidate users of getTrueMouse() controllerScriptingInterface->getReticlePosition()
4707−ivec2 Application::getTrueMouse() const {
4708− auto reticlePosition = _controllerScriptingInterface->getReticlePosition();
4708+// FIXME -- consolidate users of getTrueMouse() _compositor.getReticlePosition()
4709+ivec2 Application::getTrueMouse() {
4710+ auto reticlePosition = _compositor.getReticlePosition();
47094711 return toGlm(_glWidget->mapFromGlobal(QPoint(reticlePosition.x, reticlePosition.y)));
47104712 }
47114713