History

Added context scopes

ksuprynowicz committed 4 years ago

Commit a4c69301 parent 2b06c0910 files · +300 −95Browse files

Showing the changes to libraries/script-engine/src/v8/ScriptValueIteratorV8Wrapper.cpp (1 of 10 files). Show all

Unified · Split

libraries/script-engine/src/v8/ScriptValueIteratorV8Wrapper.cpp+2−4
@@ -18,10 +18,8 @@ V8ScriptValueIterator::V8ScriptValueIterator(ScriptEngineV8* engine, v8::Local<v · 17 unmodified lines
1818 v8::HandleScope handleScope(isolate);
1919 _context.Reset(isolate, _engine->getContext());
2020 auto context = _context.Get(isolate);
21− v8::Local<v8::Object> v8Object;
22− if (!object->ToObject(context).ToLocal(&v8Object)) {
23− Q_ASSERT(false);
24− }
21+ Q_ASSERT(object->IsObject());
22+ v8::Local<v8::Object> v8Object = v8::Local<v8::Object>::Cast(object);
2523 _object.Reset(isolate, v8Object);
2624 _propertyNames.Reset(isolate, v8Object->GetOwnPropertyNames(context).ToLocalChecked());
2725 _length = _propertyNames.Get(isolate)->Length();

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t