History

make AudioScriptingInterface a Dependency

Stephen Birarda committed 9 years ago

Commit a4d72c41 parent 20022eb5 files · +24 −19Browse files

Showing the changes to interface/src/Application.cpp (1 of 5 files). Show all

Unified · Split

interface/src/Application.cpp+11−10
@@ -740,23 +740,24 @@ Application::Application(int& argc, char** argv, QElapsedTimer& startupTimer, bo · 739 unmodified lines
740740 }
741741 });
742742
743− auto& audioScriptingInterface = AudioScriptingInterface::getInstance();
743+ auto audioScriptingInterface = DependencyManager::set<AudioScriptingInterface>();
744744 connect(audioThread, &QThread::started, audioIO.data(), &AudioClient::start);
745745 connect(audioIO.data(), &AudioClient::destroyed, audioThread, &QThread::quit);
746746 connect(audioThread, &QThread::finished, audioThread, &QThread::deleteLater);
747747 connect(audioIO.data(), &AudioClient::muteToggled, this, &Application::audioMuteToggled);
748− connect(audioIO.data(), &AudioClient::mutedByMixer, &audioScriptingInterface, &AudioScriptingInterface::mutedByMixer);
749− connect(audioIO.data(), &AudioClient::receivedFirstPacket, &audioScriptingInterface, &AudioScriptingInterface::receivedFirstPacket);
750− connect(audioIO.data(), &AudioClient::disconnected, &audioScriptingInterface, &AudioScriptingInterface::disconnected);
748+ connect(audioIO.data(), &AudioClient::mutedByMixer, audioScriptingInterface.data(), &AudioScriptingInterface::mutedByMixer);
749+ connect(audioIO.data(), &AudioClient::receivedFirstPacket, audioScriptingInterface.data(), &AudioScriptingInterface::receivedFirstPacket);
750+ connect(audioIO.data(), &AudioClient::disconnected, audioScriptingInterface.data(), &AudioScriptingInterface::disconnected);
751751 connect(audioIO.data(), &AudioClient::muteEnvironmentRequested, [](glm::vec3 position, float radius) {
752752 auto audioClient = DependencyManager::get<AudioClient>();
753+ auto audioScriptingInterface = DependencyManager::get<AudioScriptingInterface>();
753754 auto myAvatarPosition = DependencyManager::get<AvatarManager>()->getMyAvatar()->getPosition();
754755 float distance = glm::distance(myAvatarPosition, position);
755756 bool shouldMute = !audioClient->isMuted() && (distance < radius);
756757
757758 if (shouldMute) {
758759 audioClient->toggleMute();
759− AudioScriptingInterface::getInstance().environmentMuted();
760+ audioScriptingInterface->environmentMuted();
760761 }
761762 });
762763
@@ -1181,10 +1182,10 @@ Application::Application(int& argc, char** argv, QElapsedTimer& startupTimer, bo · 418 unmodified lines
11811182
11821183 // set the local loopback interface for local sounds
11831184 AudioInjector::setLocalAudioInterface(audioIO.data());
1184− AudioScriptingInterface::getInstance().setLocalAudioInterface(audioIO.data());
1185− connect(audioIO.data(), &AudioClient::noiseGateOpened, &AudioScriptingInterface::getInstance(), &AudioScriptingInterface::noiseGateOpened);
1186− connect(audioIO.data(), &AudioClient::noiseGateClosed, &AudioScriptingInterface::getInstance(), &AudioScriptingInterface::noiseGateClosed);
1187− connect(audioIO.data(), &AudioClient::inputReceived, &AudioScriptingInterface::getInstance(), &AudioScriptingInterface::inputReceived);
1185+ audioScriptingInterface->setLocalAudioInterface(audioIO.data());
1186+ connect(audioIO.data(), &AudioClient::noiseGateOpened, audioScriptingInterface.data(), &AudioScriptingInterface::noiseGateOpened);
1187+ connect(audioIO.data(), &AudioClient::noiseGateClosed, audioScriptingInterface.data(), &AudioScriptingInterface::noiseGateClosed);
1188+ connect(audioIO.data(), &AudioClient::inputReceived, audioScriptingInterface.data(), &AudioScriptingInterface::inputReceived);
11881189
11891190
11901191 this->installEventFilter(this);
@@ -1949,7 +1950,7 @@ void Application::initializeUi() { · 758 unmodified lines
19491950 // For some reason there is already an "Application" object in the QML context,
19501951 // though I can't find it. Hence, "ApplicationInterface"
19511952 rootContext->setContextProperty("ApplicationInterface", this);
1952− rootContext->setContextProperty("Audio", &AudioScriptingInterface::getInstance());
1953+ rootContext->setContextProperty("Audio", DependencyManager::get<AudioScriptingInterface>().data());
19531954 rootContext->setContextProperty("AudioStats", DependencyManager::get<AudioClient>()->getStats().data());
19541955 rootContext->setContextProperty("AudioScope", DependencyManager::get<AudioScope>().data());
19551956

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t