History

Remove _ prefix from private methods in XMLHttpRequest

Ryan Huffman committed 12 years ago

Commit a5c10221 parent dca555a2 files · +22 −22Browse files

Showing the changes to libraries/script-engine/src/XMLHttpRequestClass.cpp (1 of 2 files). Show all

Unified · Split

libraries/script-engine/src/XMLHttpRequestClass.cpp+17−17
@@ -63,7 +63,7 @@ QString XMLHttpRequestClass::getStatusText() const { · 62 unmodified lines
6363 }
6464
6565 void XMLHttpRequestClass::abort() {
66− _abortRequest();
66+ abortRequest();
6767 }
6868
6969 void XMLHttpRequestClass::setRequestHeader(const QString& name, const QString& value) {
@@ -76,18 +76,18 @@ void XMLHttpRequestClass::requestMetaDataChanged() { · 6 unmodified lines
7676 // If this is a redirect, abort the current request and start a new one
7777 if (redirect.isValid() && _numRedirects < MAXIMUM_REDIRECTS) {
7878 _numRedirects++;
79− _abortRequest();
79+ abortRequest();
8080
8181 QUrl newUrl = _url.resolved(redirect.toUrl().toString());
8282 _request.setUrl(newUrl);
83− _doSend();
83+ doSend();
8484 }
8585 }
8686
8787 void XMLHttpRequestClass::requestDownloadProgress(qint64 bytesReceived, qint64 bytesTotal) {
8888 if (_readyState == OPENED && bytesReceived > 0) {
89− _setReadyState(HEADERS_RECEIVED);
90− _setReadyState(LOADING);
89+ setReadyState(HEADERS_RECEIVED);
90+ setReadyState(LOADING);
9191 }
9292 }
9393
@@ -113,7 +113,7 @@ QScriptValue XMLHttpRequestClass::getResponseHeader(const QString& name) const { · 19 unmodified lines
113113 return QScriptValue::NullValue;
114114 }
115115
116−void XMLHttpRequestClass::_setReadyState(ReadyState readyState) {
116+void XMLHttpRequestClass::setReadyState(ReadyState readyState) {
117117 if (readyState != _readyState) {
118118 _readyState = readyState;
119119 if (_onReadyStateChange.isFunction()) {
@@ -135,7 +135,7 @@ void XMLHttpRequestClass::open(const QString& method, const QString& url, bool a · 15 unmodified lines
135135 }
136136 _request.setUrl(_url);
137137 _method = method;
138− _setReadyState(OPENED);
138+ setReadyState(OPENED);
139139 }
140140 }
141141
@@ -150,7 +150,7 @@ void XMLHttpRequestClass::send(const QString& data) { · 8 unmodified lines
150150 _sendData->setData(data.toUtf8());
151151 }
152152
153− _doSend();
153+ doSend();
154154
155155 if (!_async) {
156156 QEventLoop loop;
@@ -160,10 +160,10 @@ void XMLHttpRequestClass::send(const QString& data) { · 3 unmodified lines
160160 }
161161 }
162162
163−void XMLHttpRequestClass::_doSend() {
163+void XMLHttpRequestClass::doSend() {
164164 _reply = _manager.sendCustomRequest(_request, _method.toLatin1(), _sendData);
165165
166− _connectToReply(_reply);
166+ connectToReply(_reply);
167167
168168 if (_timeout > 0) {
169169 _timer.start(_timeout);
@@ -175,9 +175,9 @@ void XMLHttpRequestClass::requestTimeout() { · 5 unmodified lines
175175 if (_onTimeout.isFunction()) {
176176 _onTimeout.call(QScriptValue::NullValue);
177177 }
178− _abortRequest();
178+ abortRequest();
179179 _errorCode = QNetworkReply::TimeoutError;
180− _setReadyState(DONE);
180+ setReadyState(DONE);
181181 emit requestComplete();
182182 }
183183
@@ -203,29 +203,29 @@ void XMLHttpRequestClass::requestFinished() { · 19 unmodified lines
203203 _responseData = QScriptValue(QString(_rawResponseData.data()));
204204 }
205205 }
206− _setReadyState(DONE);
206+ setReadyState(DONE);
207207 emit requestComplete();
208208 }
209209
210−void XMLHttpRequestClass::_abortRequest() {
210+void XMLHttpRequestClass::abortRequest() {
211211 // Disconnect from signals we don't want to receive any longer.
212212 disconnect(&_timer, SIGNAL(timeout()), this, SLOT(requestTimeout()));
213213 if (_reply) {
214− _disconnectFromReply(_reply);
214+ disconnectFromReply(_reply);
215215 _reply->abort();
216216 delete _reply;
217217 _reply = NULL;
218218 }
219219 }
220220
221−void XMLHttpRequestClass::_connectToReply(QNetworkReply* reply) {
221+void XMLHttpRequestClass::connectToReply(QNetworkReply* reply) {
222222 connect(reply, SIGNAL(finished()), this, SLOT(requestFinished()));
223223 connect(reply, SIGNAL(error(QNetworkReply::NetworkError)), this, SLOT(requestError(QNetworkReply::NetworkError)));
224224 connect(reply, SIGNAL(downloadProgress(qint64, qint64)), this, SLOT(requestDownloadProgress(qint64, qint64)));
225225 connect(reply, SIGNAL(metaDataChanged()), this, SLOT(requestMetaDataChanged()));
226226 }
227227
228−void XMLHttpRequestClass::_disconnectFromReply(QNetworkReply* reply) {
228+void XMLHttpRequestClass::disconnectFromReply(QNetworkReply* reply) {
229229 disconnect(reply, SIGNAL(finished()), this, SLOT(requestFinished()));
230230 disconnect(reply, SIGNAL(error(QNetworkReply::NetworkError)), this, SLOT(requestError(QNetworkReply::NetworkError)));
231231 disconnect(reply, SIGNAL(downloadProgress(qint64, qint64)), this, SLOT(requestDownloadProgress(qint64, qint64)));