History

Fix V8 scope performance issue on libnode22

ksuprynowicz committed 11 months ago

Commit a9bd0781 parent 4aad6b218 files · +298 −349Browse files

Showing the changes to libraries/script-engine/src/v8/ScriptObjectV8Proxy.cpp (1 of 18 files). Show all

Unified · Split

libraries/script-engine/src/v8/ScriptObjectV8Proxy.cpp+32−55
@@ -168,8 +168,7 @@ V8ScriptValue ScriptObjectV8Proxy::newQObject(ScriptEngineV8* engine, QObject* o · 167 unmodified lines
168 168
169ScriptObjectV8Proxy* ScriptObjectV8Proxy::unwrapProxy(const V8ScriptValue& val) {169ScriptObjectV8Proxy* ScriptObjectV8Proxy::unwrapProxy(const V8ScriptValue& val) {
170 auto isolate = val.getEngine()->getIsolate();170 auto isolate = val.getEngine()->getIsolate();
171 v8::Locker locker(isolate);171 Q_ASSERT(isolate->IsCurrent());
172 v8::Isolate::Scope isolateScope(isolate);
173 v8::HandleScope handleScope(isolate);172 v8::HandleScope handleScope(isolate);
174 v8::Local<v8::Context> context = val.constGetContext();173 v8::Local<v8::Context> context = val.constGetContext();
175 v8::Context::Scope contextScope(context);174 v8::Context::Scope contextScope(context);
@@ -194,8 +193,7 @@ ScriptObjectV8Proxy* ScriptObjectV8Proxy::unwrapProxy(const V8ScriptValue& val) · 18 unmodified lines
194}193}
195 194
196ScriptObjectV8Proxy* ScriptObjectV8Proxy::unwrapProxy(v8::Isolate* isolate, v8::Local<v8::Value> &value) {195ScriptObjectV8Proxy* ScriptObjectV8Proxy::unwrapProxy(v8::Isolate* isolate, v8::Local<v8::Value> &value) {
197 v8::Locker locker(isolate);196 Q_ASSERT(isolate->IsCurrent());
198 v8::Isolate::Scope isolateScope(isolate);
199 v8::HandleScope handleScope(isolate);197 v8::HandleScope handleScope(isolate);
200 198
201 if (value->IsNullOrUndefined()) {199 if (value->IsNullOrUndefined()) {
@@ -233,18 +231,18 @@ ScriptObjectV8Proxy::~ScriptObjectV8Proxy() { · 31 unmodified lines
233 }231 }
234 }232 }
235 _wasDestroyed = true;233 _wasDestroyed = true;
234 auto isolate = _engine->getIsolate();
235 std::unique_ptr<ScriptEngine::ScriptEngineScopeGuard> guard;
236 if(!isolate->IsCurrent()) {
237 guard = _engine->getScopeGuard();
238 }
239 Q_ASSERT(isolate->IsCurrent());
236 if (_ownsObject) {240 if (_ownsObject) {
237 auto isolate = _engine->getIsolate();
238 v8::Locker locker(isolate);
239 v8::Isolate::Scope isolateScope(isolate);
240 v8::HandleScope handleScope(isolate);241 v8::HandleScope handleScope(isolate);
241 _v8Object.Reset();242 _v8Object.Reset();
242 QObject* qobject = _object;243 QObject* qobject = _object;
243 if(qobject) qobject->deleteLater();244 if(qobject) qobject->deleteLater();
244 } else {245 } else {
245 auto isolate = _engine->getIsolate();
246 v8::Locker locker(isolate);
247 v8::Isolate::Scope isolateScope(isolate);
248 v8::HandleScope handleScope(isolate);246 v8::HandleScope handleScope(isolate);
249 if (_object)247 if (_object)
250 qCDebug(scriptengine_v8) << "Deleting object proxy: " << name();248 qCDebug(scriptengine_v8) << "Deleting object proxy: " << name();
@@ -264,8 +262,7 @@ void ScriptObjectV8Proxy::investigate() { · 13 unmodified lines
264 if (!qobject) return;262 if (!qobject) return;
265 263
266 auto isolate = _engine->getIsolate();264 auto isolate = _engine->getIsolate();
267 v8::Locker locker(isolate);265 Q_ASSERT(isolate->IsCurrent());
268 v8::Isolate::Scope isolateScope(isolate);
269 v8::HandleScope handleScope(_engine->getIsolate());266 v8::HandleScope handleScope(_engine->getIsolate());
270 auto context = _engine->getContext();267 auto context = _engine->getContext();
271 v8::Context::Scope contextScope(context);268 v8::Context::Scope contextScope(context);
@@ -426,8 +423,7 @@ QString ScriptObjectV8Proxy::name() const { · 154 unmodified lines
426 423
427ScriptObjectV8Proxy::QueryFlags ScriptObjectV8Proxy::queryProperty(const V8ScriptValue& object, const V8ScriptString& name, QueryFlags flags, uint* id) {424ScriptObjectV8Proxy::QueryFlags ScriptObjectV8Proxy::queryProperty(const V8ScriptValue& object, const V8ScriptString& name, QueryFlags flags, uint* id) {
428 auto isolate = _engine->getIsolate();425 auto isolate = _engine->getIsolate();
429 v8::Locker locker(isolate);426 Q_ASSERT(isolate->IsCurrent());
430 v8::Isolate::Scope isolateScope(isolate);
431 v8::HandleScope handleScope(isolate);427 v8::HandleScope handleScope(isolate);
432 v8::Local<v8::Context> context = _engine->getContext();428 v8::Local<v8::Context> context = _engine->getContext();
433 v8::Context::Scope contextScope(context);429 v8::Context::Scope contextScope(context);
@@ -588,8 +584,7 @@ void ScriptObjectV8Proxy::v8GetPropertyNames(const v8::PropertyCallbackInfo<v8:: · 154 unmodified lines
588 584
589v8::Local<v8::Array> ScriptObjectV8Proxy::getPropertyNames() {585v8::Local<v8::Array> ScriptObjectV8Proxy::getPropertyNames() {
590 auto isolate = _engine->getIsolate();586 auto isolate = _engine->getIsolate();
591 v8::Locker locker(isolate);587 Q_ASSERT(isolate->IsCurrent());
592 v8::Isolate::Scope isolateScope(isolate);
593 v8::EscapableHandleScope handleScope(_engine->getIsolate());588 v8::EscapableHandleScope handleScope(_engine->getIsolate());
594 auto context = _engine->getContext();589 auto context = _engine->getContext();
595 v8::Context::Scope contextScope(context);590 v8::Context::Scope contextScope(context);
@@ -621,8 +616,7 @@ v8::Local<v8::Array> ScriptObjectV8Proxy::getPropertyNames() { · 25 unmodified lines
621 616
622V8ScriptValue ScriptObjectV8Proxy::property(const V8ScriptValue& object, const V8ScriptString& name, uint id) {617V8ScriptValue ScriptObjectV8Proxy::property(const V8ScriptValue& object, const V8ScriptString& name, uint id) {
623 auto isolate = _engine->getIsolate();618 auto isolate = _engine->getIsolate();
624 v8::Locker locker(isolate);619 Q_ASSERT(isolate->IsCurrent());
625 v8::Isolate::Scope isolateScope(isolate);
626 v8::HandleScope handleScope(isolate);620 v8::HandleScope handleScope(isolate);
627 auto context = _engine->getContext();621 auto context = _engine->getContext();
628 v8::Context::Scope contextScope(context);622 v8::Context::Scope contextScope(context);
@@ -694,8 +688,7 @@ V8ScriptValue ScriptObjectV8Proxy::property(const V8ScriptValue& object, const V · 65 unmodified lines
694 688
695void ScriptObjectV8Proxy::setProperty(V8ScriptValue& object, const V8ScriptString& name, uint id, const V8ScriptValue& value) {689void ScriptObjectV8Proxy::setProperty(V8ScriptValue& object, const V8ScriptString& name, uint id, const V8ScriptValue& value) {
696 auto isolate = _engine->getIsolate();690 auto isolate = _engine->getIsolate();
697 v8::Locker locker(isolate);691 Q_ASSERT(isolate->IsCurrent());
698 v8::Isolate::Scope isolateScope(isolate);
699 v8::HandleScope handleScope(isolate);692 v8::HandleScope handleScope(isolate);
700 v8::Context::Scope contextScope(_engine->getContext());693 v8::Context::Scope contextScope(_engine->getContext());
701 if (!(id & PROPERTY_TYPE)) return;694 if (!(id & PROPERTY_TYPE)) return;
@@ -733,8 +726,7 @@ void ScriptObjectV8Proxy::setProperty(V8ScriptValue& object, const V8ScriptStrin · 31 unmodified lines
733ScriptVariantV8Proxy::ScriptVariantV8Proxy(ScriptEngineV8* engine, const QVariant& variant, V8ScriptValue scriptProto, ScriptObjectV8Proxy* proto) :726ScriptVariantV8Proxy::ScriptVariantV8Proxy(ScriptEngineV8* engine, const QVariant& variant, V8ScriptValue scriptProto, ScriptObjectV8Proxy* proto) :
734 _engine(engine), _variant(variant), _scriptProto(scriptProto), _proto(proto) {727 _engine(engine), _variant(variant), _scriptProto(scriptProto), _proto(proto) {
735 auto isolate = engine->getIsolate();728 auto isolate = engine->getIsolate();
736 v8::Locker locker(isolate);729 Q_ASSERT(isolate->IsCurrent());
737 v8::Isolate::Scope isolateScope(isolate);
738 v8::HandleScope handleScope(isolate);730 v8::HandleScope handleScope(isolate);
739 auto context = engine->getContext();731 auto context = engine->getContext();
740 v8::Context::Scope contextScope(context);732 v8::Context::Scope contextScope(context);
@@ -749,8 +741,7 @@ ScriptVariantV8Proxy::ScriptVariantV8Proxy(ScriptEngineV8* engine, const QVarian · 8 unmodified lines
749 741
750ScriptVariantV8Proxy::~ScriptVariantV8Proxy() {742ScriptVariantV8Proxy::~ScriptVariantV8Proxy() {
751 auto isolate = _engine->getIsolate();743 auto isolate = _engine->getIsolate();
752 v8::Locker locker(isolate);744 Q_ASSERT(isolate->IsCurrent());
753 v8::Isolate::Scope isolateScope(isolate);
754 v8::HandleScope handleScope(isolate);745 v8::HandleScope handleScope(isolate);
755 // V8TODO: Add similar deletion handling as for object proxy746 // V8TODO: Add similar deletion handling as for object proxy
756 _v8Object.Reset();747 _v8Object.Reset();
@@ -759,8 +750,7 @@ ScriptVariantV8Proxy::~ScriptVariantV8Proxy() { · 2 unmodified lines
759V8ScriptValue ScriptVariantV8Proxy::newVariant(ScriptEngineV8* engine, const QVariant& variant, V8ScriptValue proto) {750V8ScriptValue ScriptVariantV8Proxy::newVariant(ScriptEngineV8* engine, const QVariant& variant, V8ScriptValue proto) {
760 qDebug() << "ScriptVariantV8Proxy::newVariant";751 qDebug() << "ScriptVariantV8Proxy::newVariant";
761 auto isolate = engine->getIsolate();752 auto isolate = engine->getIsolate();
762 v8::Locker locker(isolate);753 Q_ASSERT(isolate->IsCurrent());
763 v8::Isolate::Scope isolateScope(isolate);
764 v8::HandleScope handleScope(isolate);754 v8::HandleScope handleScope(isolate);
765 auto context = engine->getContext();755 auto context = engine->getContext();
766 v8::Context::Scope contextScope(context);756 v8::Context::Scope contextScope(context);
@@ -782,8 +772,7 @@ V8ScriptValue ScriptVariantV8Proxy::newVariant(ScriptEngineV8* engine, const QVa · 15 unmodified lines
782 772
783ScriptVariantV8Proxy* ScriptVariantV8Proxy::unwrapProxy(const V8ScriptValue& val) {773ScriptVariantV8Proxy* ScriptVariantV8Proxy::unwrapProxy(const V8ScriptValue& val) {
784 auto isolate = val.getEngine()->getIsolate();774 auto isolate = val.getEngine()->getIsolate();
785 v8::Locker locker(isolate);775 Q_ASSERT(isolate->IsCurrent());
786 v8::Isolate::Scope isolateScope(isolate);
787 v8::HandleScope handleScope(isolate);776 v8::HandleScope handleScope(isolate);
788 v8::Context::Scope contextScope(val.getEngine()->getContext());777 v8::Context::Scope contextScope(val.getEngine()->getContext());
789 778
@@ -802,8 +791,7 @@ ScriptVariantV8Proxy* ScriptVariantV8Proxy::unwrapProxy(const V8ScriptValue& val · 12 unmodified lines
802}791}
803 792
804ScriptVariantV8Proxy* ScriptVariantV8Proxy::unwrapProxy(v8::Isolate* isolate, v8::Local<v8::Value> &value) {793ScriptVariantV8Proxy* ScriptVariantV8Proxy::unwrapProxy(v8::Isolate* isolate, v8::Local<v8::Value> &value) {
805 v8::Locker locker(isolate);794 Q_ASSERT(isolate->IsCurrent());
806 v8::Isolate::Scope isolateScope(isolate);
807 v8::HandleScope handleScope(isolate);795 v8::HandleScope handleScope(isolate);
808 796
809 if (!value->IsObject()) {797 if (!value->IsObject()) {
@@ -820,8 +808,7 @@ ScriptVariantV8Proxy* ScriptVariantV8Proxy::unwrapProxy(v8::Isolate* isolate, v8 · 10 unmodified lines
820}808}
821 809
822QVariant* ScriptVariantV8Proxy::unwrapQVariantPointer(v8::Isolate* isolate, const v8::Local<v8::Value> &value) {810QVariant* ScriptVariantV8Proxy::unwrapQVariantPointer(v8::Isolate* isolate, const v8::Local<v8::Value> &value) {
823 v8::Locker locker(isolate);811 Q_ASSERT(isolate->IsCurrent());
824 v8::Isolate::Scope isolateScope(isolate);
825 v8::HandleScope handleScope(isolate);812 v8::HandleScope handleScope(isolate);
826 813
827 if (!value->IsObject()) {814 if (!value->IsObject()) {
@@ -924,8 +911,7 @@ ScriptMethodV8Proxy::ScriptMethodV8Proxy(ScriptEngineV8* engine, QObject* object · 96 unmodified lines
924 const QList<QMetaMethod>& metas, int numMaxParams) :911 const QList<QMetaMethod>& metas, int numMaxParams) :
925 _numMaxParams(numMaxParams), _engine(engine), _object(object), /*_objectLifetime(lifetime),*/ _metas(metas) {912 _numMaxParams(numMaxParams), _engine(engine), _object(object), /*_objectLifetime(lifetime),*/ _metas(metas) {
926 auto isolate = engine->getIsolate();913 auto isolate = engine->getIsolate();
927 v8::Locker locker(isolate);914 Q_ASSERT(isolate->IsCurrent());
928 v8::Isolate::Scope isolateScope(isolate);
929 v8::HandleScope handleScope(isolate);915 v8::HandleScope handleScope(isolate);
930 v8::Context::Scope contextScope(engine->getContext());916 v8::Context::Scope contextScope(engine->getContext());
931 _objectLifetime.Reset(isolate, lifetime.get());917 _objectLifetime.Reset(isolate, lifetime.get());
@@ -934,8 +920,7 @@ ScriptMethodV8Proxy::ScriptMethodV8Proxy(ScriptEngineV8* engine, QObject* object · 2 unmodified lines
934 920
935ScriptMethodV8Proxy::~ScriptMethodV8Proxy() {921ScriptMethodV8Proxy::~ScriptMethodV8Proxy() {
936 auto isolate = _engine->getIsolate();922 auto isolate = _engine->getIsolate();
937 v8::Locker locker(isolate);923 Q_ASSERT(isolate->IsCurrent());
938 v8::Isolate::Scope isolateScope(isolate);
939 v8::HandleScope handleScope(isolate);924 v8::HandleScope handleScope(isolate);
940 _objectLifetime.Reset();925 _objectLifetime.Reset();
941}926}
@@ -949,8 +934,7 @@ void ScriptMethodV8Proxy::weakHandleCallback(const v8::WeakCallbackInfo<ScriptMe · 7 unmodified lines
949V8ScriptValue ScriptMethodV8Proxy::newMethod(ScriptEngineV8* engine, QObject* object, V8ScriptValue lifetime,934V8ScriptValue ScriptMethodV8Proxy::newMethod(ScriptEngineV8* engine, QObject* object, V8ScriptValue lifetime,
950 const QList<QMetaMethod>& metas, int numMaxParams) {935 const QList<QMetaMethod>& metas, int numMaxParams) {
951 auto isolate = engine->getIsolate();936 auto isolate = engine->getIsolate();
952 v8::Locker locker(isolate);937 Q_ASSERT(isolate->IsCurrent());
953 v8::Isolate::Scope isolateScope(isolate);
954 v8::HandleScope handleScope(isolate);938 v8::HandleScope handleScope(isolate);
955 auto context = engine->getContext();939 auto context = engine->getContext();
956 v8::Context::Scope contextScope(context);940 v8::Context::Scope contextScope(context);
@@ -975,8 +959,7 @@ QString ScriptMethodV8Proxy::fullName() const { · 18 unmodified lines
975}959}
976 960
977void ScriptMethodV8Proxy::callback(const v8::FunctionCallbackInfo<v8::Value>& arguments) {961void ScriptMethodV8Proxy::callback(const v8::FunctionCallbackInfo<v8::Value>& arguments) {
978 v8::Locker locker(arguments.GetIsolate());962 Q_ASSERT(arguments.GetIsolate()->IsCurrent());
979 v8::Isolate::Scope isolateScope(arguments.GetIsolate());
980 v8::HandleScope handleScope(arguments.GetIsolate());963 v8::HandleScope handleScope(arguments.GetIsolate());
981 v8::Context::Scope contextScope(arguments.GetIsolate()->GetCurrentContext());964 v8::Context::Scope contextScope(arguments.GetIsolate()->GetCurrentContext());
982 if (!arguments.Data()->IsObject()) {965 if (!arguments.Data()->IsObject()) {
@@ -1001,8 +984,7 @@ void ScriptMethodV8Proxy::callback(const v8::FunctionCallbackInfo<v8::Value>& ar · 18 unmodified lines
1001void ScriptMethodV8Proxy::call(const v8::FunctionCallbackInfo<v8::Value>& arguments) {984void ScriptMethodV8Proxy::call(const v8::FunctionCallbackInfo<v8::Value>& arguments) {
1002 v8::Isolate *isolate = arguments.GetIsolate();985 v8::Isolate *isolate = arguments.GetIsolate();
1003 Q_ASSERT(isolate == _engine->getIsolate());986 Q_ASSERT(isolate == _engine->getIsolate());
1004 v8::Locker locker(isolate);987 Q_ASSERT(isolate->IsCurrent());
1005 v8::Isolate::Scope isolateScope(isolate);
1006 v8::HandleScope handleScope(isolate);988 v8::HandleScope handleScope(isolate);
1007 ContextScopeV8 contextScopeV8(_engine);989 ContextScopeV8 contextScopeV8(_engine);
1008 auto context = _engine->getContext();990 auto context = _engine->getContext();
@@ -1192,8 +1174,7 @@ void ScriptMethodV8Proxy::call(const v8::FunctionCallbackInfo<v8::Value>& argume · 183 unmodified lines
1192ScriptSignalV8Proxy::ScriptSignalV8Proxy(ScriptEngineV8* engine, QObject* object, V8ScriptValue lifetime, const QMetaMethod& meta) :1174ScriptSignalV8Proxy::ScriptSignalV8Proxy(ScriptEngineV8* engine, QObject* object, V8ScriptValue lifetime, const QMetaMethod& meta) :
1193 _engine(engine), _object(object), _meta(meta), _metaCallId(discoverMetaCallIdx()) {1175 _engine(engine), _object(object), _meta(meta), _metaCallId(discoverMetaCallIdx()) {
1194 auto isolate = _engine->getIsolate();1176 auto isolate = _engine->getIsolate();
1195 v8::Locker locker(isolate);1177 Q_ASSERT(isolate->IsCurrent());
1196 v8::Isolate::Scope isolateScope(isolate);
1197 v8::HandleScope handleScope(isolate);1178 v8::HandleScope handleScope(isolate);
1198 auto context = _engine->getContext();1179 auto context = _engine->getContext();
1199 v8::Context::Scope contextScope(context);1180 v8::Context::Scope contextScope(context);
@@ -1211,8 +1192,7 @@ ScriptSignalV8Proxy::~ScriptSignalV8Proxy() { · 11 unmodified lines
1211 }1192 }
1212 1193
1213 auto isolate = _engine->getIsolate();1194 auto isolate = _engine->getIsolate();
1214 v8::Locker locker(isolate);1195 Q_ASSERT(isolate->IsCurrent());
1215 v8::Isolate::Scope isolateScope(isolate);
1216 v8::HandleScope handleScope(isolate);1196 v8::HandleScope handleScope(isolate);
1217 _objectLifetime.Reset();1197 _objectLifetime.Reset();
1218 _v8Context.Reset();1198 _v8Context.Reset();
@@ -1260,8 +1240,7 @@ int ScriptSignalV8Proxy::qt_metacall(QMetaObject::Call call, int id, void** argu · 41 unmodified lines
1260#endif1240#endif
1261 1241
1262 auto isolate = _engine->getIsolate();1242 auto isolate = _engine->getIsolate();
1263 v8::Locker locker(isolate);1243 Q_ASSERT(isolate->IsCurrent());
1264 v8::Isolate::Scope isolateScope(isolate);
1265 1244
1266 QList<Connection> connections;1245 QList<Connection> connections;
1267 withReadLock([&]{1246 withReadLock([&]{
@@ -1348,9 +1327,9 @@ int ScriptSignalV8Proxy::discoverMetaCallIdx() { · 80 unmodified lines
1348 1327
1349ScriptSignalV8Proxy::ConnectionList::iterator ScriptSignalV8Proxy::findConnection(V8ScriptValue thisObject, V8ScriptValue callback) {1328ScriptSignalV8Proxy::ConnectionList::iterator ScriptSignalV8Proxy::findConnection(V8ScriptValue thisObject, V8ScriptValue callback) {
1350 auto iterOut = resultWithReadLock<ScriptSignalV8Proxy::ConnectionList::iterator>([&]{1329 auto iterOut = resultWithReadLock<ScriptSignalV8Proxy::ConnectionList::iterator>([&]{
1351 v8::Locker locker(_engine->getIsolate());1330 auto isolate = _engine->getIsolate();
1352 v8::Isolate::Scope isolateScope(_engine->getIsolate());1331 Q_ASSERT(isolate->IsCurrent());
1353 v8::HandleScope handleScope(_engine->getIsolate());1332 v8::HandleScope handleScope(isolate);
1354 v8::Context::Scope contextScope(_engine->getContext());1333 v8::Context::Scope contextScope(_engine->getContext());
1355 ConnectionList::iterator iter;1334 ConnectionList::iterator iter;
1356 for (iter = _connections.begin(); iter != _connections.end(); ++iter) {1335 for (iter = _connections.begin(); iter != _connections.end(); ++iter) {
@@ -1366,8 +1345,7 @@ ScriptSignalV8Proxy::ConnectionList::iterator ScriptSignalV8Proxy::findConnectio · 9 unmodified lines
1366 1345
1367void ScriptSignalV8Proxy::connect(ScriptValue arg0, ScriptValue arg1) {1346void ScriptSignalV8Proxy::connect(ScriptValue arg0, ScriptValue arg1) {
1368 v8::Isolate *isolate = _engine->getIsolate();1347 v8::Isolate *isolate = _engine->getIsolate();
1369 v8::Locker locker(isolate);1348 Q_ASSERT(isolate->IsCurrent());
1370 v8::Isolate::Scope isolateScope(isolate);
1371 v8::HandleScope handleScope(isolate);1349 v8::HandleScope handleScope(isolate);
1372 auto context = _engine->getContext();1350 auto context = _engine->getContext();
1373 v8::Context::Scope contextScope(context);1351 v8::Context::Scope contextScope(context);
@@ -1496,8 +1474,7 @@ void ScriptSignalV8Proxy::disconnect(ScriptValue arg0, ScriptValue arg1) { · 122 unmodified lines
1496 return;1474 return;
1497 }1475 }
1498 }1476 }
1499 v8::Locker locker(isolate);1477 Q_ASSERT(isolate->IsCurrent());
1500 v8::Isolate::Scope isolateScope(isolate);
1501 v8::HandleScope handleScope(isolate);1478 v8::HandleScope handleScope(isolate);
1502 auto context = _engine->getContext();1479 auto context = _engine->getContext();
1503 v8::Context::Scope contextScope(context);1480 v8::Context::Scope contextScope(context);

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t