History

code review

Seth Alves committed 10 years ago

Commit aa58cad1 parent 3f5ed4b3 files · +11 −5Browse files

Showing the changes to libraries/script-engine/src/ScriptEngines.cpp (1 of 3 files). Show all

Unified · Split

libraries/script-engine/src/ScriptEngines.cpp+1−4
@@ -160,7 +160,6 @@ void ScriptEngines::shutdownScripting() { · 159 unmodified lines
160160 scriptEngine->disconnect(this);
161161
162162 // Gracefully stop the engine's scripting thread
163− scriptEngine->setIsStopping();
164163 scriptEngine->stop();
165164
166165 // We need to wait for the engine to be done running before we proceed, because we don't
@@ -352,8 +351,7 @@ void ScriptEngines::stopAllScripts(bool restart) { · 185 unmodified lines
352351 reloadScript(scriptName);
353352 });
354353 }
355− it.value()->setIsStopping();
356− QMetaObject::invokeMethod(it.value(), "stop");
354+ it.value()->stop();
357355 qCDebug(scriptengine) << "stopping script..." << it.key();
358356 }
359357 }
@@ -376,7 +374,6 @@ bool ScriptEngines::stopScript(const QString& rawScriptURL, bool restart) { · 16 unmodified lines
376374 reloadScript(scriptName);
377375 });
378376 }
379− scriptEngine->setIsStopping();
380377 scriptEngine->stop();
381378 stoppedScript = true;
382379 qCDebug(scriptengine) << "stopping script..." << scriptURL;