History

beware null sessionID

Andrew Meadows committed 7 years ago

Commit ab419dd1 parent e7001c31 file · +6 −2Browse files

Showing the changes to libraries/entities/src/EntityScriptingInterface.cpp (1 of 1 file). Show all

Unified · Split

libraries/entities/src/EntityScriptingInterface.cpp+6−2
@@ -481,11 +481,15 @@ QUuid EntityScriptingInterface::addEntityInternal(const EntityItemProperties& pr · 480 unmodified lines
481481 _activityTracking.addedEntityCount++;
482482
483483 auto nodeList = DependencyManager::get<NodeList>();
484− const auto sessionID = nodeList->getSessionUUID();
484+ auto sessionID = nodeList->getSessionUUID();
485485
486486 EntityItemProperties propertiesWithSimID = properties;
487487 propertiesWithSimID.setEntityHostType(entityHostType);
488488 if (entityHostType == entity::HostType::AVATAR) {
489+ if (sessionID.isNull()) {
490+ // null sessionID is unacceptable in this case
491+ sessionID = AVATAR_SELF_ID;
492+ }
489493 propertiesWithSimID.setOwningAvatarID(sessionID);
490494 } else if (entityHostType == entity::HostType::LOCAL) {
491495 // For now, local entities are always collisionless
@@ -801,7 +805,7 @@ QUuid EntityScriptingInterface::editEntity(const QUuid& id, const EntityItemProp · 309 unmodified lines
801805 return;
802806 }
803807
804− if (entity->isAvatarEntity() && entity->getOwningAvatarID() != sessionID) {
808+ if (entity->isAvatarEntity() && entity->getOwningAvatarID() != sessionID && entity->getOwningAvatarID() != AVATAR_SELF_ID) {
805809 // don't edit other avatar's avatarEntities
806810 properties = EntityItemProperties();
807811 return;