History

Code review feedback

Added comment to explain removal of displayPlugin->resetSensors from Application::resetSensors()

Anthony Thibault committed 8 years ago

Commit ac828101 parent ac8869e1 file · +4 −1Browse files

Showing the changes to interface/src/Application.cpp (1 of 1 file). Show all

Unified · Split

interface/src/Application.cpp+4−1
@@ -6468,10 +6468,13 @@ void Application::copyDisplayViewFrustum(ViewFrustum& viewOut) const { · 6467 unmodified lines
64686468 viewOut = _displayViewFrustum;
64696469 }
64706470
6471+// resentSensors() is a bit of vestigial feature. It used to be used for Oculus DK2 to recenter the view around
6472+// the current head orientation. With the introduction of "room scale" tracking we no longer need that particular
6473+// feature. However, we still use this to reset face trackers, eye trackers, audio and to optionally re-load the avatar
6474+// rig and animations from scratch.
64716475 void Application::resetSensors(bool andReload) {
64726476 DependencyManager::get<DdeFaceTracker>()->reset();
64736477 DependencyManager::get<EyeTracker>()->reset();
6474− //getActiveDisplayPlugin()->resetSensors();
64756478 _overlayConductor.centerUI();
64766479 getMyAvatar()->reset(true, andReload);
64776480 QMetaObject::invokeMethod(DependencyManager::get<AudioClient>().data(), "reset", Qt::QueuedConnection);

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t