History

Further work on V8

ksuprynowicz committed 3 years ago

Commit acbec551 parent b786ffc2 files · +10 −1Browse files

Showing the changes to libraries/script-engine/src/v8/ScriptEngineV8_cast.cpp (1 of 2 files). Show all

Unified · Split

libraries/script-engine/src/v8/ScriptEngineV8_cast.cpp+3−0
@@ -344,6 +344,8 @@ bool ScriptEngineV8::castValueToVariant(const V8ScriptValue& v8Val, QVariant& de · 343 unmodified lines
344344 if (demarshalFunc) {
345345 dest = QVariant(destTypeId, static_cast<void*>(NULL));
346346 ScriptValue wrappedVal(new ScriptValueV8Wrapper(this, v8Val));
347+ Q_ASSERT(dest.constData() != nullptr);
348+ //V8TODO: Data should never be written to dest.constData() according to Qt documentation.
347349 bool success = demarshalFunc(wrappedVal, const_cast<void*>(dest.constData()));
348350 if(!success) dest = QVariant();
349351 return success;
@@ -689,6 +691,7 @@ V8ScriptValue ScriptEngineV8::castVariantToValue(const QVariant& val) { · 339 unmodified lines
689691 _customTypeProtect.unlock();
690692 }
691693 if (marshalFunc) {
694+ Q_ASSERT(val.constData() != nullptr);
692695 ScriptValue wrappedVal = marshalFunc(this, val.constData());
693696 return ScriptValueV8Wrapper::fullUnwrap(this, wrappedVal);
694697 }

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t