History

Review fix: add flag to choose whether to abort script on exception

Dale Glass committed 3 years ago

Commit acd19f71 parent aec756b4 files · +34 −6Browse files

Showing the changes to tests/script-engine/src/ScriptEngineTests.cpp (1 of 4 files). Show all

Unified · Split

tests/script-engine/src/ScriptEngineTests.cpp+8−2
@@ -57,6 +57,8 @@ ScriptManagerPointer ScriptEngineTests::makeManager(const QString &scriptSource, · 56 unmodified lines
57 ScriptManagerPointer sm = newScriptManager(ScriptManager::NETWORKLESS_TEST_SCRIPT, scriptSource, scriptFilename);57 ScriptManagerPointer sm = newScriptManager(ScriptManager::NETWORKLESS_TEST_SCRIPT, scriptSource, scriptFilename);
58 58
59 59
60 sm->setAbortOnUncaughtException(true);
61
60 connect(sm.get(), &ScriptManager::scriptLoaded, [](const QString& filename){62 connect(sm.get(), &ScriptManager::scriptLoaded, [](const QString& filename){
61 qWarning() << "Loaded script" << filename;63 qWarning() << "Loaded script" << filename;
62 });64 });
@@ -227,8 +229,7 @@ void ScriptEngineTests::testRaiseExceptionAndCatch() { · 164 unmodified lines
227 " print(\"Caught!\");"229 " print(\"Caught!\");"
228 " }"230 " }"
229 "}"231 "}"
230 "Script.stop(true);"232 "Script.stop(true);";
231 ;
232 233
233 QString printed;234 QString printed;
234 auto sm = makeManager(script, "testRaiseCatch.js");235 auto sm = makeManager(script, "testRaiseCatch.js");
@@ -248,6 +249,11 @@ void ScriptEngineTests::testRaiseExceptionAndCatch() { · 13 unmodified lines
248}249}
249 250
250 251
252void ScriptEngineTests::testSignal() {
253
254}
255
256
251void ScriptEngineTests::scriptTest() {257void ScriptEngineTests::scriptTest() {
252 return;258 return;
253 259