Register metatypes, fixes warnings

Remove executeOnScriptThread from Script JS API -- seems unused, is marked deprecated, and for some reason registration didn't resolve the warnings.

Dale Glass committed 3 years ago

Commit aec756b1 parent 8f827502 files · +9 −1Browse files

Showing the changes to libraries/script-engine/src/ScriptManagerScriptingInterface.h (1 of 2 files). Show all

Unified · Split

      * @param {ConnectionType} [type=2] - Connection type.
      * @deprecated This function is deprecated and will be removed.
      */
-    Q_INVOKABLE void executeOnScriptThread(std::function<void()> function, const Qt::ConnectionType& type = Qt::QueuedConnection ) { _manager->executeOnScriptThread(function, type);}
+    // V8TODO: Nothing seems to be using this, and it generates:
+    // hifi.scriptengine: Parameter  1 in method  ScriptManagerScriptingInterface :: "executeOnScriptThread"  is of type QMetaType::UnknownType
+    // so removing for now.
+    //
+    // Q_INVOKABLE void executeOnScriptThread(std::function<void()> function, const Qt::ConnectionType& type = Qt::QueuedConnection ) { _manager->executeOnScriptThread(function, type);}
     /**jsdoc
      * @function Script._requireResolve