History

Register metatypes, fixes warnings

Remove executeOnScriptThread from Script JS API -- seems unused, is marked deprecated, and for some reason registration didn't resolve the warnings.

Dale Glass committed 3 years ago

Commit aec756b1 parent 8f827502 files · +9 −1Browse files

Showing the changes to libraries/script-engine/src/ScriptManagerScriptingInterface.h (1 of 2 files). Show all

Unified · Split

libraries/script-engine/src/ScriptManagerScriptingInterface.h+5−1
@@ -672,7 +672,11 @@ protected: · 671 unmodified lines
672672 * @param {ConnectionType} [type=2] - Connection type.
673673 * @deprecated This function is deprecated and will be removed.
674674 */
675− Q_INVOKABLE void executeOnScriptThread(std::function<void()> function, const Qt::ConnectionType& type = Qt::QueuedConnection ) { _manager->executeOnScriptThread(function, type);}
675+ // V8TODO: Nothing seems to be using this, and it generates:
676+ // hifi.scriptengine: Parameter 1 in method ScriptManagerScriptingInterface :: "executeOnScriptThread" is of type QMetaType::UnknownType
677+ // so removing for now.
678+ //
679+ // Q_INVOKABLE void executeOnScriptThread(std::function<void()> function, const Qt::ConnectionType& type = Qt::QueuedConnection ) { _manager->executeOnScriptThread(function, type);}
676680
677681 /**jsdoc
678682 * @function Script._requireResolve