History

fix operations of two different enums

RTUnreal committed 1 year ago

Commit b306e211 parent 2d96c024 files · +19 −15Browse files

Showing the changes to interface/src/Menu.cpp (1 of 4 files). Show all

Unified · Split

interface/src/Menu.cpp+11−8
@@ -15,6 +15,9 @@ · 14 unmodified lines
1515 // This forces QML files to be pulled from the source as you edit it: set environment variable HIFI_USE_SOURCE_TREE_RESOURCES=1
1616 // Use this to live reload: DependencyManager::get<OffscreenUi>()->clearCache();
1717
18+
19+// QT6TODO: The Key Enums should be replaced by QKeyCombination in Qt6
20+
1821 #include "Menu.h"
1922 #include <QDesktopServices>
2023 #include <QFileDialog>
@@ -106,7 +109,7 @@ Menu::Menu() { · 85 unmodified lines
106109 });
107110
108111 // File > Quit
109− addActionToQMenuAndActionHash(fileMenu, MenuOption::Quit, Qt::CTRL | Qt::Key_Q, qApp, SLOT(quit()), QAction::QuitRole);
112+ addActionToQMenuAndActionHash(fileMenu, MenuOption::Quit, static_cast<int>(Qt::CTRL) | static_cast<int>(Qt::Key_Q), qApp, SLOT(quit()), QAction::QuitRole);
110113
111114
112115 // Edit menu ----------------------------------
@@ -143,7 +146,7 @@ Menu::Menu() { · 30 unmodified lines
143146 editMenu->addSeparator();
144147
145148 // Edit > Running Scripts
146− auto action = addActionToQMenuAndActionHash(editMenu, MenuOption::RunningScripts, Qt::CTRL | Qt::Key_J);
149+ auto action = addActionToQMenuAndActionHash(editMenu, MenuOption::RunningScripts, static_cast<int>(Qt::CTRL) | static_cast<int>(Qt::Key_J));
147150 connect(action, &QAction::triggered, [] {
148151 if (!qApp->getLoginDialogPoppedUp()) {
149152 static const QUrl widgetUrl("hifi/dialogs/RunningScripts.qml");
@@ -157,7 +160,7 @@ Menu::Menu() { · 7 unmodified lines
157160
158161 // Edit > Asset Browser
159162 auto assetServerAction = addActionToQMenuAndActionHash(editMenu, MenuOption::AssetServer,
160− Qt::CTRL | Qt::SHIFT | Qt::Key_A,
163+ static_cast<int>(Qt::CTRL | Qt::SHIFT) | static_cast<int>(Qt::Key_A),
161164 qApp, SLOT(showAssetServerWidget()));
162165 {
163166 auto nodeList = DependencyManager::get<NodeList>();
@@ -253,7 +256,7 @@ Menu::Menu() { · 89 unmodified lines
253256 MenuWrapper* settingsMenu = addMenu("Settings");
254257
255258 // Settings > General...
256− action = addActionToQMenuAndActionHash(settingsMenu, MenuOption::Preferences, Qt::CTRL | Qt::Key_G, nullptr, nullptr);
259+ action = addActionToQMenuAndActionHash(settingsMenu, MenuOption::Preferences, static_cast<int>(Qt::CTRL) | static_cast<int>(Qt::Key_G), nullptr, nullptr);
257260 connect(action, &QAction::triggered, [] {
258261 if (!qApp->getLoginDialogPoppedUp()) {
259262 qApp->showDialog(QString("hifi/dialogs/GeneralPreferencesDialog.qml"),
@@ -337,7 +340,7 @@ Menu::Menu() { · 77 unmodified lines
337340 MenuWrapper* scriptingOptionsMenu = developerMenu->addMenu("Scripting");
338341
339342 // Developer > Scripting > Console...
340− addActionToQMenuAndActionHash(scriptingOptionsMenu, MenuOption::Console, Qt::CTRL | Qt::ALT | Qt::Key_J,
343+ addActionToQMenuAndActionHash(scriptingOptionsMenu, MenuOption::Console, static_cast<int>(Qt::CTRL | Qt::ALT) | static_cast<int>(Qt::Key_J),
341344 DependencyManager::get<StandAloneJSConsole>().data(),
342345 SLOT(toggleConsole()),
343346 QAction::NoRole,
@@ -379,7 +382,7 @@ Menu::Menu() { · 35 unmodified lines
379382 #if defined(Q_OS_MAC) || defined(Q_OS_WIN)
380383 auto speechRecognizer = DependencyManager::get<SpeechRecognizer>();
381384 QAction* speechRecognizerAction = addCheckableActionToQMenuAndActionHash(scriptingOptionsMenu, MenuOption::ControlWithSpeech,
382− Qt::CTRL | Qt::SHIFT | Qt::Key_C,
385+ static_cast<int>(Qt::CTRL | Qt::SHIFT) | static_cast<int>(Qt::Key_C),
383386 speechRecognizer->getEnabled(),
384387 speechRecognizer.data(),
385388 SLOT(setEnabled(bool)),
@@ -815,7 +818,7 @@ Menu::Menu() { · 429 unmodified lines
815818 addCheckableActionToQMenuAndActionHash(developerMenu, MenuOption::AnimStats);
816819
817820 // Developer > Log
818− addActionToQMenuAndActionHash(developerMenu, MenuOption::Log, Qt::CTRL | Qt::SHIFT | Qt::Key_L,
821+ addActionToQMenuAndActionHash(developerMenu, MenuOption::Log, static_cast<int>(Qt::CTRL | Qt::SHIFT) | static_cast<int>(Qt::Key_L),
819822 qApp, SLOT(toggleLogDialog()));
820823
821824 #if 0 /// -------------- REMOVED FOR NOW --------------
@@ -834,7 +837,7 @@ Menu::Menu() { · 12 unmodified lines
834837 MenuWrapper* toolsMenu = addMenu("Tools");
835838 addActionToQMenuAndActionHash(toolsMenu,
836839 MenuOption::ToolWindow,
837− Qt::CTRL | Qt::ALT | Qt::Key_T,
840+ static_cast<int>(Qt::CTRL | Qt::ALT) | static_cast<int>(Qt::Key_T),
838841 dialogsManager.data(),
839842 SLOT(toggleToolWindow()),
840843 QAction::NoRole, UNSPECIFIED_POSITION, "Advanced");