History

Don't use blocking connections on the main thread

Brad Davis committed 9 years ago

Commit b52dd7b1 parent b22daa945 files · +377 −178Browse files

Showing the changes to interface/src/scripting/MenuScriptingInterface.cpp (1 of 45 files). Show all

Unified · Split

interface/src/scripting/MenuScriptingInterface.cpp+6−5
@@ -14,6 +14,7 @@ · 13 unmodified lines
1414 #include <QtCore/QCoreApplication>
1515 #include <QtCore/QThread>
1616
17+#include <shared/QtHelpers.h>
1718 #include <MenuItemProperties.h>
1819 #include "Menu.h"
1920
@@ -43,7 +44,7 @@ bool MenuScriptingInterface::menuExists(const QString& menu) { · 23 unmodified lines
4344 return Menu::getInstance()->menuExists(menu);
4445 }
4546 bool result;
46− QMetaObject::invokeMethod(Menu::getInstance(), "menuExists", Qt::BlockingQueuedConnection,
47+ hifi::qt::blockingInvokeMethod(Menu::getInstance(), "menuExists",
4748 Q_RETURN_ARG(bool, result),
4849 Q_ARG(const QString&, menu));
4950 return result;
@@ -86,7 +87,7 @@ bool MenuScriptingInterface::menuItemExists(const QString& menu, const QString& · 36 unmodified lines
8687 return Menu::getInstance()->menuItemExists(menu, menuitem);
8788 }
8889 bool result;
89− QMetaObject::invokeMethod(Menu::getInstance(), "menuItemExists", Qt::BlockingQueuedConnection,
90+ hifi::qt::blockingInvokeMethod(Menu::getInstance(), "menuItemExists",
9091 Q_RETURN_ARG(bool, result),
9192 Q_ARG(const QString&, menu),
9293 Q_ARG(const QString&, menuitem));
@@ -114,7 +115,7 @@ bool MenuScriptingInterface::isOptionChecked(const QString& menuOption) { · 21 unmodified lines
114115 return Menu::getInstance()->isOptionChecked(menuOption);
115116 }
116117 bool result;
117− QMetaObject::invokeMethod(Menu::getInstance(), "isOptionChecked", Qt::BlockingQueuedConnection,
118+ hifi::qt::blockingInvokeMethod(Menu::getInstance(), "isOptionChecked",
118119 Q_RETURN_ARG(bool, result),
119120 Q_ARG(const QString&, menuOption));
120121 return result;
@@ -131,7 +132,7 @@ bool MenuScriptingInterface::isMenuEnabled(const QString& menuOption) { · 10 unmodified lines
131132 return Menu::getInstance()->isOptionChecked(menuOption);
132133 }
133134 bool result;
134− QMetaObject::invokeMethod(Menu::getInstance(), "isMenuEnabled", Qt::BlockingQueuedConnection,
135+ hifi::qt::blockingInvokeMethod(Menu::getInstance(), "isMenuEnabled",
135136 Q_RETURN_ARG(bool, result),
136137 Q_ARG(const QString&, menuOption));
137138 return result;
@@ -157,7 +158,7 @@ bool MenuScriptingInterface::isInfoViewVisible(const QString& path) { · 19 unmodified lines
157158 }
158159
159160 bool result;
160− QMetaObject::invokeMethod(Menu::getInstance(), "isInfoViewVisible", Qt::BlockingQueuedConnection,
161+ hifi::qt::blockingInvokeMethod(Menu::getInstance(), "isInfoViewVisible",
161162 Q_RETURN_ARG(bool, result), Q_ARG(const QString&, path));
162163 return result;
163164 }