History

Added more debug info to crash with signals

ksuprynowicz committed 3 years ago

Commit b786ffc1 parent 3e692a62 files · +45 −29Browse files

Showing the changes to libraries/script-engine/src/v8/ScriptEngineV8.cpp (1 of 2 files). Show all

Unified · Split

libraries/script-engine/src/v8/ScriptEngineV8.cpp+6−0
@@ -393,7 +393,13 @@ ScriptEngineV8::ScriptEngineV8(ScriptManager* scriptManager) : · 392 unmodified lines
393393 //
394394 // Based on that, going with 256K for stacks for now. That seems like a reasonable value.
395395 // We'll probably need a more complex system on the longer term, with configurable limits.
396+ // Flags to try:
397+ // V8TODO --single-threaded is to check if it fixes random crashes
398+ // --jitless - might improve debugging performance due to no JIT?
399+ // --assert-types
400+
396401 v8::V8::SetFlagsFromString("--stack-size=256");
402+ //v8::V8::SetFlagsFromString("--stack-size=256 --single-threaded");
397403 v8::Platform* platform = getV8Platform();
398404 v8::V8::InitializePlatform(platform);
399405 v8::V8::Initialize(); qCDebug(scriptengine) << "V8 platform initialized";