History

Whitelist toggle not working c++ side.

Kasen IO committed 6 years ago

Commit bd066ad1 parent 15e9d083 files · +128 −61Browse files

Showing the changes to libraries/script-engine/src/ScriptEngine.cpp (1 of 3 files). Show all

Unified · Split

libraries/script-engine/src/ScriptEngine.cpp+15−3
@@ -2333,7 +2333,7 @@ void ScriptEngine::entityScriptContentAvailable(const EntityItemID& entityID, co · 2332 unmodified lines
23332333 if (isURL) {
23342334 setParentURL(scriptOrURL);
23352335 }
2336−
2336+
23372337 // SANITY/PERFORMANCE CHECK USING SANDBOX
23382338 const int SANDBOX_TIMEOUT = 0.25 * MSECS_PER_SECOND;
23392339 BaseScriptEngine sandbox;
@@ -2369,11 +2369,23 @@ void ScriptEngine::entityScriptContentAvailable(const EntityItemID& entityID, co · 29 unmodified lines
23692369 QList<QString> safeURLPrefixes = { "file:///", "atp:", "cache:" };
23702370 safeURLPrefixes += qEnvironmentVariable("EXTRA_WHITELIST").trimmed().split(QRegExp("\\s*,\\s*"), QString::SkipEmptyParts);
23712371
2372− // IF WHITELIST IS DISABLED IN SETTINGS
2373− bool whitelistEnabled = Setting::Handle<bool>("private/whitelistEnabled", true).get();
2372+ // ENTITY SCRIPT WHITELIST TOGGLE CHECK
2373+ Setting::Handle<bool> whitelistEnabledSetting{"private/whitelistEnabled", true}; // Assume it is enabled.
2374+ bool whitelistEnabled = whitelistEnabledSetting.get();
2375+
2376+ // QVariant whitelistEnabledExists = Setting::Handle<QVariant>("private/whitelistEnabled", false).get();
2377+ if (whitelistEnabled) {
2378+ whitelistEnabledSetting.set(true);
2379+ qCDebug(scriptengine) << "Whitelist toggle setting does not exist. Creating setting now.";
2380+ } else {
2381+ qCDebug(scriptengine) << "Whitelist toggle setting does not exist. Creating setting now.";
2382+ whitelistEnabledSetting.set(false);
2383+ }
2384+
23742385 if (!whitelistEnabled) {
23752386 passList = true;
23762387 }
2388+ qCDebug(scriptengine) << "Whitelist Enabled: " << whitelistEnabled;
23772389
23782390 // PULL SAFEURLS FROM INTERFACE.JSON Settings
23792391 QVariant raw = Setting::Handle<QVariant>("private/settingsSafeURLS").get();