History

significant cleanup of ScriptEngineQtScript (which isn't exposed to the scripting engine and shouldn't be @jsdoc'ed)

Heather Anderson committed 5 years ago

Commit bd4a0351 parent ef16b835 files · +17 −288Browse files

Showing the changes to libraries/script-engine/src/qtscript/ScriptEngineQtScript.cpp (1 of 5 files). Show all

Unified · Split

libraries/script-engine/src/qtscript/ScriptEngineQtScript.cpp+0−37
@@ -354,37 +354,10 @@ ScriptEngineQtScript::ScriptEngineQtScript(ScriptManager* scriptManager) : · 353 unmodified lines
354354 setAgent(_contextAgent);
355355 }
356356
357−bool ScriptEngineQtScript::isDebugMode() const {
358−#if defined(DEBUG)
359− return true;
360−#else
361− return false;
362−#endif
363−}
364−
365357 ScriptEngineQtScript::~ScriptEngineQtScript() {
366358 delete _contextAgent;
367359 }
368360
369−void ScriptEngineQtScript::disconnectNonEssentialSignals() {
370− disconnect();
371− QThread* workerThread;
372− // Ensure the thread should be running, and does exist
373− if (_isRunning && _isThreaded && (workerThread = QScriptEngine::thread())) {
374− connect(this, &QObject::destroyed, workerThread, &QThread::quit);
375− connect(workerThread, &QThread::finished, workerThread, &QObject::deleteLater);
376− }
377−}
378−
379−void ScriptEngineQtScript::executeOnScriptThread(std::function<void()> function, const Qt::ConnectionType& type ) {
380− if (QThread::currentThread() != QScriptEngine::thread()) {
381− QMetaObject::invokeMethod(this, "executeOnScriptThread", type, Q_ARG(std::function<void()>, function));
382− return;
383− }
384−
385− function();
386−}
387−
388361 void ScriptEngineQtScript::registerEnum(const QString& enumName, QMetaEnum newEnum) {
389362 if (!newEnum.isValid()) {
390363 qCCritical(scriptengine) << "registerEnum called on invalid enum with name " << enumName;
@@ -768,16 +741,6 @@ void ScriptEngineQtScript::updateMemoryCost(const qint64& deltaSize) { · 377 unmodified lines
768741 }
769742 }
770743
771−void ScriptEngineQtScript::print(const QString& message) {
772− QString filename;
773− auto scriptManager = manager();
774− if (scriptManager) {
775− filename = scriptManager->getFilename();
776− }
777−
778− emit printedMessage(message, filename);
779−}
780−
781744
782745 ////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
783746 // ScriptEngine implementation

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t