History

force script value destruction to enqueue

RTUnreal committed 8 months ago

Commit be540e41 parent b7f85d24 files · +13 −2Browse files

Showing the changes to libraries/script-engine/src/v8/ScriptValueV8Wrapper.cpp (1 of 4 files). Show all

Unified · Split

libraries/script-engine/src/v8/ScriptValueV8Wrapper.cpp+5−0
@@ -19,6 +19,11 @@ · 18 unmodified lines
19#include "../ScriptEngineLogging.h"19#include "../ScriptEngineLogging.h"
20#include "ScriptEngineLoggingV8.h"20#include "ScriptEngineLoggingV8.h"
21 21
22
23void ScriptValueV8Wrapper::enqueueRelease() {
24 _engine->scheduleValueWrapperForDeletion(this);
25}
26
22void ScriptValueV8Wrapper::release() {27void ScriptValueV8Wrapper::release() {
23 // Check if ScriptValueV8Wrapper::release was called from inside ScriptValueV8Wrapper functions, and if so, delete it later28 // Check if ScriptValueV8Wrapper::release was called from inside ScriptValueV8Wrapper functions, and if so, delete it later
24 // This prevents access-after-delete crashes when ScriptValueV8Wrapper::release is called from inside JS executed in29 // This prevents access-after-delete crashes when ScriptValueV8Wrapper::release is called from inside JS executed in

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t