History

Moving running scripts functionality to scripting library

Brad Davis committed 10 years ago

Commit d28f80a1 parent ddd9b0820 files · +664 −569Browse files

Showing the changes to interface/src/ui/ScriptEditorWidget.cpp (1 of 20 files). Show all

Unified · Split

interface/src/ui/ScriptEditorWidget.cpp+8−5
@@ -25,6 +25,7 @@ · 24 unmodified lines
2525 #include <QTimer>
2626 #include <QWidget>
2727
28+#include <ScriptEngines.h>
2829 #include <NetworkAccessManager.h>
2930 #include <OffscreenUi.h>
3031
@@ -101,17 +102,18 @@ bool ScriptEditorWidget::setRunning(bool run) { · 70 unmodified lines
101102 disconnect(_scriptEngine, &ScriptEngine::finished, this, &ScriptEditorWidget::onScriptFinished);
102103 }
103104
105+ auto scriptEngines = DependencyManager::get<ScriptEngines>();
104106 if (run) {
105107 const QString& scriptURLString = QUrl(_currentScript).toString();
106108 // Reload script so that an out of date copy is not retrieved from the cache
107− _scriptEngine = qApp->loadScript(scriptURLString, true, true, false, true);
109+ _scriptEngine = scriptEngines->loadScript(scriptURLString, true, true, false, true);
108110 connect(_scriptEngine, &ScriptEngine::runningStateChanged, this, &ScriptEditorWidget::runningStateChanged);
109111 connect(_scriptEngine, &ScriptEngine::update, this, &ScriptEditorWidget::onScriptModified);
110112 connect(_scriptEngine, &ScriptEngine::finished, this, &ScriptEditorWidget::onScriptFinished);
111113 } else {
112114 connect(_scriptEngine, &ScriptEngine::finished, this, &ScriptEditorWidget::onScriptFinished);
113115 const QString& scriptURLString = QUrl(_currentScript).toString();
114− qApp->stopScript(scriptURLString);
116+ scriptEngines->stopScript(scriptURLString);
115117 _scriptEngine = NULL;
116118 }
117119 _console->setScriptEngine(_scriptEngine);
@@ -173,7 +175,7 @@ void ScriptEditorWidget::loadFile(const QString& scriptPath) { · 55 unmodified lines
173175 }
174176 }
175177 const QString& scriptURLString = QUrl(_currentScript).toString();
176− _scriptEngine = qApp->getScriptEngine(scriptURLString);
178+ _scriptEngine = DependencyManager::get<ScriptEngines>()->getScriptEngine(scriptURLString);
177179 if (_scriptEngine != NULL) {
178180 connect(_scriptEngine, &ScriptEngine::runningStateChanged, this, &ScriptEditorWidget::runningStateChanged);
179181 connect(_scriptEngine, &ScriptEngine::update, this, &ScriptEditorWidget::onScriptModified);
@@ -187,11 +189,12 @@ bool ScriptEditorWidget::save() { · 7 unmodified lines
187189 }
188190
189191 bool ScriptEditorWidget::saveAs() {
192+ auto scriptEngines = DependencyManager::get<ScriptEngines>();
190193 QString fileName = QFileDialog::getSaveFileName(this, tr("Save script"),
191− qApp->getPreviousScriptLocation(),
194+ scriptEngines->getPreviousScriptLocation(),
192195 tr("JavaScript Files (*.js)"));
193196 if (!fileName.isEmpty()) {
194− qApp->setPreviousScriptLocation(fileName);
197+ scriptEngines->setPreviousScriptLocation(fileName);
195198 return saveFile(fileName);
196199 } else {
197200 return false;