History

Add defaultScriptsOverride option

Ryan Huffman committed 7 years ago

Commit d29cd791 parent b9558624 files · +31 −7Browse files

Showing the changes to libraries/script-engine/src/ScriptEngines.cpp (1 of 4 files). Show all

Unified · Split

libraries/script-engine/src/ScriptEngines.cpp+19−5
@@ -29,6 +29,7 @@ static const QString DESKTOP_LOCATION = QStandardPaths::writableLocation(QStanda · 28 unmodified lines
2929 static const bool HIFI_SCRIPT_DEBUGGABLES { true };
3030 static const QString SETTINGS_KEY { "RunningScripts" };
3131 static const QUrl DEFAULT_SCRIPTS_LOCATION { "file:///~//defaultScripts.js" };
32+
3233 // Using a QVariantList so this is human-readable in the settings file
3334 static Setting::Handle<QVariantList> runningScriptsHandle(SETTINGS_KEY, { QVariant(DEFAULT_SCRIPTS_LOCATION) });
3435
@@ -64,8 +65,8 @@ void ScriptEngines::onErrorLoadingScript(const QString& url) { · 29 unmodified lines
6465 emit errorLoadingScript(url);
6566 }
6667
67−ScriptEngines::ScriptEngines(ScriptEngine::Context context)
68− : _context(context)
68+ScriptEngines::ScriptEngines(ScriptEngine::Context context, const QUrl& defaultScriptsOverride)
69+ : _context(context), _defaultScriptsOverride(defaultScriptsOverride)
6970 {
7071 _scriptsModelFilter.setSourceModel(&_scriptsModel);
7172 _scriptsModelFilter.sort(0, Qt::AscendingOrder);
@@ -322,13 +323,22 @@ void ScriptEngines::loadScripts() { · 250 unmodified lines
322323
323324 // loads all saved scripts
324325 auto runningScripts = runningScriptsHandle.get();
326+ bool defaultScriptsOverrideSet = !_defaultScriptsOverride.isEmpty();
325327
326328 for (auto script : runningScripts) {
327− auto string = script.toString();
328− if (!string.isEmpty()) {
329− loadScript(string);
329+ auto url = script.toUrl();
330+ if (!url.isEmpty()) {
331+ if (defaultScriptsOverrideSet && url == DEFAULT_SCRIPTS_LOCATION) {
332+ _defaultScriptsWasRunning = true;
333+ } else {
334+ loadScript(url);
335+ }
330336 }
331337 }
338+
339+ if (defaultScriptsOverrideSet) {
340+ loadScript(_defaultScriptsOverride, false);
341+ }
332342 }
333343
334344 void ScriptEngines::saveScripts() {
@@ -359,6 +369,10 @@ void ScriptEngines::saveScripts() { · 24 unmodified lines
359369 }
360370 }
361371
372+ if (_defaultScriptsWasRunning) {
373+ list.append(DEFAULT_SCRIPTS_LOCATION);
374+ }
375+
362376 runningScriptsHandle.set(list);
363377 }
364378

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t