Fixes

EdgarPironti committed 10 years ago

Commit df215311 parent e70f6852 files · +15 −8Browse files

Showing the changes to libraries/script-engine/src/RecordingScriptingInterface.cpp (1 of 2 files). Show all

Unified · Split

libraries/script-engine/src/RecordingScriptingInterface.cpp+14−5

 #include <recording/Frame.h>
 #include <recording/ClipCache.h>
+#include <QtScript/QScriptValue>
+#include <AssetClient.h>
+#include <AssetUpload.h>
 #include <QtCore/QUrl>
 #include <QtWidgets/QFileDialog>
 }
 bool RecordingScriptingInterface::saveRecordingToAsset(QScriptValue getClipAtpUrl) {
-	if (!getClipAtpUrl.isFunction())
+    if (!getClipAtpUrl.isFunction()) {
+        qCWarning(scriptengine) << "The argument is not a function.";
         return false;
+    }
     if (QThread::currentThread() != thread()) {
+        bool result{ false };
         QMetaObject::invokeMethod(this, "saveRecordingToAsset", Qt::BlockingQueuedConnection,
-            Q_ARG(QScriptValue, getClipAtpUrl));
+            Q_ARG(QScriptValue, getClipAtpUrl),
-        return false;
+            Q_RETURN_ARG(bool, result));
+        return result;
     }
     if (!_lastClip) {
     if (auto upload = DependencyManager::get<AssetClient>()->createUpload(recording::Clip::toBuffer(_lastClip), HFR_EXTENSION)) {
         QObject::connect(upload, &AssetUpload::finished, this, [=](AssetUpload* upload, const QString& hash) mutable {
-            auto filename = QFileInfo(upload->getFilename()).fileName();
             QString clip_atp_url = "";
             if (upload->getError() == AssetUpload::NoError) {
                 clip_atp_url = QString("%1:%2.%3").arg(URL_SCHEME_ATP, hash, upload->getExtension());
                 upload->deleteLater();
             } else {
-                qDebug() << "Error during the Asset upload.";
+                qCWarning(scriptengine) << "Error during the Asset upload.";
             }
             QScriptValueList args;
         return true;
     }
+    qCWarning(scriptengine) << "Saving on asset failed.";
     return false;
 }