History

Merge branch 'master' of https://github.com/highfidelity/hifi into NUEtweaks

Brad Hefta-Gaub committed 10 years ago

Commit e478b722 parents 8b51746 466b5359 files · +434 −44Browse files

Showing the changes to interface/src/Application.cpp (1 of 9 files). Show all

Unified · Split

interface/src/Application.cpp+1−25
@@ -210,9 +210,7 @@ const QHash<QString, Application::AcceptURLMethod> Application::_acceptedExtensi · 209 unmodified lines
210210
211211 class DeadlockWatchdogThread : public QThread {
212212 public:
213− static const unsigned long HEARTBEAT_CHECK_INTERVAL_SECS = 1;
214213 static const unsigned long HEARTBEAT_UPDATE_INTERVAL_SECS = 1;
215− static const unsigned long HEARTBEAT_REPORT_INTERVAL_USECS = 5 * USECS_PER_SECOND;
216214 static const unsigned long MAX_HEARTBEAT_AGE_USECS = 30 * USECS_PER_SECOND;
217215 static const int WARNING_ELAPSED_HEARTBEAT = 500 * USECS_PER_MSEC; // warn if elapsed heartbeat average is large
218216 static const int HEARTBEAT_SAMPLES = 100000; // ~5 seconds worth of samples
@@ -239,8 +237,6 @@ public: · 20 unmodified lines
239237 *crashTrigger = 0xDEAD10CC;
240238 }
241239
242− static void setSuppressStatus(bool suppress) { _suppressStatus = suppress; }
243−
244240 void run() override {
245241 while (!_quit) {
246242 QThread::sleep(HEARTBEAT_UPDATE_INTERVAL_SECS);
@@ -248,7 +244,6 @@ public: · 1 unmodified line
248244 uint64_t lastHeartbeat = _heartbeat; // sample atomic _heartbeat, because we could context switch away and have it updated on us
249245 uint64_t now = usecTimestampNow();
250246 auto lastHeartbeatAge = (now > lastHeartbeat) ? now - lastHeartbeat : 0;
251− auto sinceLastReport = (now > _lastReport) ? now - _lastReport : 0;
252247 auto elapsedMovingAverage = _movingAverage.getAverage();
253248
254249 if (elapsedMovingAverage > _maxElapsedAverage) {
@@ -274,21 +269,10 @@ public: · 19 unmodified lines
274269 if (elapsedMovingAverage > WARNING_ELAPSED_HEARTBEAT) {
275270 qDebug() << "DEADLOCK WATCHDOG WARNING:"
276271 << "lastHeartbeatAge:" << lastHeartbeatAge
277− << "elapsedMovingAverage:" << elapsedMovingAverage << "** OVER EXPECTED VALUE**"
278− << "maxElapsed:" << _maxElapsed
279− << "maxElapsedAverage:" << _maxElapsedAverage
280− << "samples:" << _movingAverage.getSamples();
281− _lastReport = now;
282− }
283−
284− if (!_suppressStatus && sinceLastReport > HEARTBEAT_REPORT_INTERVAL_USECS) {
285− qDebug() << "DEADLOCK WATCHDOG STATUS:"
286− << "lastHeartbeatAge:" << lastHeartbeatAge
287− << "elapsedMovingAverage:" << elapsedMovingAverage
272+ << "elapsedMovingAverage:" << elapsedMovingAverage << "** OVER EXPECTED VALUE **"
288273 << "maxElapsed:" << _maxElapsed
289274 << "maxElapsedAverage:" << _maxElapsedAverage
290275 << "samples:" << _movingAverage.getSamples();
291− _lastReport = now;
292276 }
293277
294278 if (lastHeartbeatAge > MAX_HEARTBEAT_AGE_USECS) {
@@ -310,9 +294,7 @@ public: · 15 unmodified lines
310294 }
311295 }
312296
313− static std::atomic<bool> _suppressStatus;
314297 static std::atomic<uint64_t> _heartbeat;
315− static std::atomic<uint64_t> _lastReport;
316298 static std::atomic<uint64_t> _maxElapsed;
317299 static std::atomic<int> _maxElapsedAverage;
318300 static ThreadSafeMovingAverage<int, HEARTBEAT_SAMPLES> _movingAverage;
@@ -320,17 +302,11 @@ public: · 1 unmodified line
320302 bool _quit { false };
321303 };
322304
323−std::atomic<bool> DeadlockWatchdogThread::_suppressStatus;
324305 std::atomic<uint64_t> DeadlockWatchdogThread::_heartbeat;
325−std::atomic<uint64_t> DeadlockWatchdogThread::_lastReport;
326306 std::atomic<uint64_t> DeadlockWatchdogThread::_maxElapsed;
327307 std::atomic<int> DeadlockWatchdogThread::_maxElapsedAverage;
328308 ThreadSafeMovingAverage<int, DeadlockWatchdogThread::HEARTBEAT_SAMPLES> DeadlockWatchdogThread::_movingAverage;
329309
330−void Application::toggleSuppressDeadlockWatchdogStatus(bool checked) {
331− DeadlockWatchdogThread::setSuppressStatus(checked);
332−}
333−
334310 #ifdef Q_OS_WIN
335311 class MyNativeEventFilter : public QAbstractNativeEventFilter {
336312 public:

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t