History

Temporary fix for some script messages not being transmitted

ksuprynowicz committed 2 years ago

Commit e4907161 parent 9a2f0f71 file · +18 −0Browse files

Showing the changes to libraries/script-engine/src/ScriptManager.cpp (1 of 1 file). Show all

Unified · Split

libraries/script-engine/src/ScriptManager.cpp+18−0
@@ -589,6 +589,10 @@ void ScriptManager::scriptErrorMessage(const QString& message, const QString& fi · 588 unmodified lines
589589 emit errorMessage(message, getFilename());
590590 if (!currentEntityIdentifier.isInvalidID()) {
591591 emit errorEntityMessage(message, fileName, lineNumber, currentEntityIdentifier, isEntityServerScript());
592+ } else {
593+ if (isEntityServerScript()) {
594+ emit errorEntityMessage(message, fileName, lineNumber, EntityItemID(), isEntityServerScript());
595+ }
592596 }
593597 }
594598
@@ -597,6 +601,10 @@ void ScriptManager::scriptWarningMessage(const QString& message, const QString& · 2 unmodified lines
597601 emit warningMessage(message, getFilename());
598602 if (!currentEntityIdentifier.isInvalidID()) {
599603 emit warningEntityMessage(message, fileName, lineNumber, currentEntityIdentifier, isEntityServerScript());
604+ } else {
605+ if (isEntityServerScript()) {
606+ emit warningEntityMessage(message, fileName, lineNumber, EntityItemID(), isEntityServerScript());
607+ }
600608 }
601609 }
602610
@@ -605,6 +613,10 @@ void ScriptManager::scriptInfoMessage(const QString& message, const QString& fil · 2 unmodified lines
605613 emit infoMessage(message, getFilename());
606614 if (!currentEntityIdentifier.isInvalidID()) {
607615 emit infoEntityMessage(message, fileName, lineNumber, currentEntityIdentifier, isEntityServerScript());
616+ } else {
617+ if (isEntityServerScript()) {
618+ emit infoEntityMessage(message, fileName, lineNumber, EntityItemID(), isEntityServerScript());
619+ }
608620 }
609621 }
610622
@@ -613,6 +625,12 @@ void ScriptManager::scriptPrintedMessage(const QString& message, const QString& · 2 unmodified lines
613625 emit printedMessage(message, getFilename());
614626 if (!currentEntityIdentifier.isInvalidID()) {
615627 emit printedEntityMessage(message, fileName, lineNumber, currentEntityIdentifier, isEntityServerScript());
628+ } else {
629+ if (isEntityServerScript()) {
630+ // TODO: Some callbacks like for example websockets one right now
631+ // don't set currentEntityIdentifier and there doesn't seem to be easy way to add it currently
632+ emit printedEntityMessage(message, fileName, lineNumber, EntityItemID(), isEntityServerScript());
633+ }
616634 }
617635 }
618636